rpeg
February 1, 2017, 8:51am
1
I’ve assumed that “Build failing” means the package in question on Github doesn’t work but I read one comment elsewhere suggesting otherwise. What does it mean and pertain to?
1 Like
I haven’t seen this at github before. But “build” suggests a compiled language like Java not compiling. I.e. The build fails
Or it isn’t passing the automated tests they may have setup. Which means there could be a bug in the package or the test is written poorly.
rpeg
February 1, 2017, 7:21pm
4
Can you explain what you mean by automated tests? I understand the idea of some languages require builds but for this particular javascript package, I guess I don’t get it.
The package in question
Yeah, it has a tests directory and some of those tests are failing.
He also references the tests in the Contributing.md file
# Opening an Issue
The GitHub issue tracker is exclusively for opening demonstrable bugs with the library or for discussing/implementing enhancements. If you need general help with Waypoints try searching through existing closed tickets, searching through the [#jquery-waypoints](http://stackoverflow.com/questions/tagged/jquery-waypoints) tag on StackOverflow, or asking your question there using that tag. If you do ask a question on StackOverflow, please follow the guidelines for [asking a good question](http://stackoverflow.com/help/how-to-ask).
If you're opening a ticket for a bug:
- Give a clear explanation of the bug.
- Try to provide a link to a [JSFiddle](http://jsfiddle.net/) or [CodePen](http://codepen.io/) or similar reduced test case.
- If you cannot provide a reduced test case, please provide a link to a live site demonstrating your bug and include in the ticket the relevant Waypoints code.
If you're interested in discussing a possible new feature:
- Search closed tickets for discussions that may have already occurred.
- Open a ticket and let's talk!
# Pull Requests
- Please send the pull request against the master branch.
- Note any tickets that the pull request addresses.
- Add any necessary tests (see below).
This file has been truncated. show original
Unfortunately, he doesn’t link to where his tests are running, Travis CI (is a common one) and is indeed the one they are using
And their build history
https://travis-ci.org/imakewebthings/waypoints/builds
2 Likes
rpeg
February 1, 2017, 7:54pm
6
Okay thanks. I am unfamiliar with this aspect of Github. I will need to learn more about it including Travis Cl. If I look up the subject, should I just look up “testing on github” or something like that?
I’d start with the Travis-CI documentation
1 Like
system
Closed
May 4, 2017, 3:03am
8
This topic was automatically closed 91 days after the last reply. New replies are no longer allowed.