Hi,
I have an HTML table with several submit buttons that pass an id to my controller. But I don’t seem to be sending the correct id’s. I can’t see what is wrong with the form.
managetopic.html.php
subtopics table looks like this,
The topics table looks like this,
The form itself looks like this,
Here is an excerpt from the index.php controller file.
if (isset($_POST['action']) and $_POST['action'] == 'Edittopic')
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
try
{
$sql = 'SELECT id, topic FROM topics WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error fetching topic row details.';
include 'error.html.php';
echo $e;
exit();
}
$row = $s->fetch();
$pageTitle = 'Edit a row of the topic table';
$action = 'edittopicform';
$name = $row['topic'];
$id = $row['id'];
$formid = 'topic';
$button = 'Update topic';
include 'topicform.html.php';
exit();
}
if (isset($_GET['edittopicform']))
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
try
{
$sql = 'UPDATE topics SET
topic = :topic
WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->bindValue(':topic', $_POST['topic']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error updating submitted topic.';
include 'error.html.php';
echo $e;
exit();
}
header('Location: managetopics.html.php');
exit();
}
if (isset($_POST['action']) and $_POST['action'] == 'Deletetopic')
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
// Delete the topic
try
{
$sql = 'DELETE FROM topics WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error deleting topic.';
include 'error.html.php';
exit();
}
header('Location: managetopics.html.php');
exit();
}
if (isset($_POST['action']) and $_POST['action'] == 'Editsubtopic')
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
try
{
$sql = 'SELECT id, subtopic FROM subtopics WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error fetching subtopic row details.';
include 'error.html.php';
echo $e;
exit();
}
$row = $s->fetch();
$pageTitle = 'Edit a row of the sub-topic table';
$action = 'editformsubtopic';
$name = $row['subtopic'];
$id = $row['id'];
$formid = 'subtopic';
$button = 'Update sub-topic';
// Build the list of sub-topic rows
try
{
$result = $pdo->query('SELECT id, subtopic FROM subtopics');
}
catch (PDOException $e)
{
$error = 'Error fetching list of subtopics.';
include 'error.html.php';
echo $e;
exit();
}
foreach ($result as $row)
{
$subtopics[] = array('id' => $row['id'], 'subtopic' => $row['subtopic']);
}
include 'topicform.html.php';
exit();
}
if (isset($_GET['editformsubtopic']))
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
try
{
$sql = 'UPDATE subtopics SET
subtopic = :subtopic
WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->bindValue(':subtopic', $_POST['subtopic']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error updating submitted sub-topic.';
include 'error.html.php';
echo $e;
exit();
}
header('Location: ?topics');
exit();
}
if (isset($_POST['action']) and $_POST['action'] == 'Deletesubtopic')
{
include $_SERVER['DOCUMENT_ROOT'] . '/artgibney/includes/db.inc.php';
// Delete the subtopic
try
{
$sql = 'DELETE FROM subtopics WHERE id = :id';
$s = $pdo->prepare($sql);
$s->bindValue(':id', $_POST['id']);
$s->execute();
}
catch (PDOException $e)
{
$error = 'Error deleting sub-topic.';
include 'error.html.php';
echo $e;
exit();
}
header('Location: managetopics.html.php');
exit();
}
Any help would be greatly appreciated,
Thanks,
Shane
Previously I had this form as two tables, but when I put them together I have problems. When I click edit or delete, a different topic or subtopic is edited or deleted.
This is what i had before
Which looked like this, giving the information in two tables,
But in the first post you can see that it displays the topic along with it’s associated subtopics.
Could the problem be with the name=“id” being the same for the ‘edit’ and ‘delete’ buttons for both topic and subtopic?
Shane
Yes thanks, good idea. I will do that.
Seems to be only dealing with the id in the last row of each array.
But I will see what output your suggestion gives.
Thanks,
Shane
Hi,
I have it working now. I split the form into two forms within the same table and made a few other non related changes.
But first I used your suggestion,
