Removing setInterval

JavaScript
21

The above code has this added to it:

Init Function

function init(opts) {
    loadPlayer();
    if (apiIsReady) {
      addVideo(opts.video, opts.playerVars || {});
    }
    else
    {
      waitting_inits.push(opts)
    }
}

CallBack Function

window.onYouTubePlayerAPIReady = function() {
  apiIsReady = true;
  load_all_waitting_inits()
};


var waitting_inits=[];
function load_all_waitting_inits()
{
    for(var opts of waitting_inits)
  {
    init(opts);
  }
}
22

Yes, that also waits until the time is right for those inits to occur. That is a good way of doing things too, and is preferable to using setInterval.

23

If I remove this line from the code, the browser freezes.
apiIsReady = true;

How would that be fixed?

24

Remove this line from the code.
apiIsReady = true;

Then try clicking on the image.

That’s why I thought it was a bad code.

Do you see what I mean?

25

You can get rid of apiIsReady completely.

Where it was used in the if statement, just check for YT instead. That’s the youtube api.

26

Could you re-write these parts so it’s better written?

I don’t want the browser to keep freezing on me.

Init Function

function init(opts) {
    loadPlayer();
    if (apiIsReady) {
      addVideo(opts.video, opts.playerVars || {});
    }
    else
    {
      waitting_inits.push(opts)
    }
}

CallBack Function

window.onYouTubePlayerAPIReady = function() {
  apiIsReady = true;
  load_all_waitting_inits()
};


var waitting_inits=[];
function load_all_waitting_inits()
{
    for(var opts of waitting_inits)
  {
    init(opts);
  }
}
27

See above about apiIsReady.

Also, waitting_inits.forEach(init);

28

I’m not touching the jsfiddle though.
When I get it right on here, you can share it with me.

const waitting_inits=[];
function load_all_waitting_inits()
{
    waitting_inits.forEach(init);
  {
    init(opts);
  }
}
29

I don’t understand how removing a piece of javascript from a code can make your browser freeze. It froze my whole pc.

30

All of this can be deleted then, right?

  let apiIsReady = false;
    let timer;
    window.onYouTubePlayerAPIReady = function() {
        apiIsReady = true;
    };

The code works with all of that removed:

1 Like
31

@Paul_Wilkins

All of this occurs after clicking on 1 video box.
Does that make logical sense?

image
image1098×428 39.8 KB

32

@Paul_Wilkins

That even happens with the, setInterval Code.

That can’t be good.

33

Yes, that makes sense.

34

Why, can you explain?

35

It’s the youtube API that’s doing those things to load the video.

36

Over 50 domains loading?

After 1 video box is clicked.

37

That’s how the sausage is made.

1 Like
38

Over 64 requests after 1 video is clicked?

That’s insane.

39

Welcome to YouTube.

40

Just this gets 30 + requests.

<iframe width="198" height="198" src="https://www.youtube.com/embed/M7lc1UVf-VE" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>