Need help on Insert data to phpMyAdmin

PHP
1

Hi guys, I would like to seek help on inserting data whenever the switch is on or off to my sensor mySQL database in phpMyAdmin from my control.php. I’m using Raspberry PI as my hardware and follow a few tutorials to create my own Web Control Interface, it works perfectly without insert method. After I implemented insert method to my control.php and execute it, it cannot works and cannot store.

This is my control.php:


<?php
session_start();

$MySQLUsername = "MySQLUsername";
$MYSQLUsersensor = "MYSQLUsersensor";
$MySQLPassword = "MySQLPassword";


$MySQLHost = "localhost";
$MySQLDB = "gpio";
$MYSQLDBsensor = "sensor";

If (($MySQLUsername == "USERNAME HERE") || ($MySQLPassword == "PASSWORD HERE")){
	print 'ERROR - Please set up the script first';
	exit();
}

$dbConnection = mysql_connect($MySQLHost, $MySQLUsername, $MySQLPassword);
mysql_select_db($MySQLDB, $dbConnection);
If (isset($_POST['action'])){
	If ($_POST['action'] == "setPassword"){
		$password1 = $_POST['password1'];
		$password2 = $_POST['password2'];
		If ($password1 != $password2){
			header('Location: control.php');
		}
		$password = mysql_real_escape_string($_POST['password1']);
		If (strlen($password) > 28){
			mysql_close();
			header('location: control.php');
		}
		$resetQuery = "SELECT username, salt FROM users WHERE username = 'admin';";
		$resetResult = mysql_query($resetQuery);
		If (mysql_num_rows($resetResult) < 1){
			mysql_close();
			header('location: control.php');
		}
		$resetData = mysql_fetch_array($resetResult, MYSQL_ASSOC);
		$resetHash = hash('sha256', $salt . hash('sha256', $password));
		$hash = hash('sha256', $password);
		function createSalt(){
			$string = md5(uniqid(rand(), true));
			return substr($string, 0, 8);
		}
		$salt = createSalt();
		$hash = hash('sha256', $salt . $hash);
		mysql_query("UPDATE users SET salt='$salt' WHERE username='admin'");
		mysql_query("UPDATE users SET password='$hash' WHERE username='admin'");
		mysql_close();
		header('location: control.php');
	}
}
If ((isset($_POST['username'])) && (isset($_POST['password']))){
	$username = mysql_real_escape_string($_POST['username']);
	$password = mysql_real_escape_string($_POST['password']);
	$loginQuery = "SELECT UserID, password, salt FROM users WHERE username = '$username';";
	$loginResult = mysql_query($loginQuery);
	If (mysql_num_rows($loginResult) < 1){
		mysql_close();
		header('location: control.php?error=incorrectLogin');
	}
	$loginData = mysql_fetch_array($loginResult, MYSQL_ASSOC);
	$loginHash = hash('sha256', $loginData['salt'] . hash('sha256', $password));
	If ($loginHash != $loginData['password']){
		mysql_close();
		header('location: control.php?error=incorrectLogin');
	} else {
		session_regenerate_id();
		$_SESSION['username'] = "admin";
		$_SESSION['userID'] = "1";
		mysql_close();
		header('location: control.php');
	}
}
If ((!isset($_SESSION['username'])) || (!isset($_SESSION['userID']))){
	print '
	<html>
	<head>
	<title>GPIO Control - Login</title>
	</head>
	<body>
	<table border="0" align="center">
	<form name="login" action="control.php" method="post">
	<tr>
	<td>Username: </td><td><input type="text" name="username"></td>
	</tr>
	<tr>
	<td>Password: </td><td><input type="password" name="password"></td>
	</tr>
	<tr>
	<td colspan="2" align="center"><input type="submit" value="Log In"></td>
	</tr>
	</form>
	</table>
	</body>
	</html>
	';
	die();
}
If (isset($_GET['action'])){
	If ($_GET['action'] == "logout"){
		$_SESSION = array();
		session_destroy();
		header('Location: control.php');
	} else If ($_GET['action'] == "setPassword"){
		print '
		<form name="changePassword" action="control.php" method="post">
		<input type="hidden" name="action" value="setPassword">
		<p>Enter New Password: <input type="password" name="password1">  Confirm: <input type="password" name="password2"><input type="submit" value="submit"></p>
		</form>
		';
	} else {
                $now = new DateTime();
		$action = $_GET['action'];
		$pin = mysql_real_escape_string($_GET['pin']);
		if ($action == "turnOn"){
			$setting = "1";
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='4';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('1', 'Red LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='17';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('2', 'Blue LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='18';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('3', 'Green LED', , '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='21';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('4', 'LED', $now, '')");
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='22';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('5', 'LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='23';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('6', 'LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='24';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('7', 'LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='25';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('8', 'LED', $now, '')");
			mysql_close();
			header('Location: control.php');
		} else If ($action == "turnOff"){
			$setting = "0";
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='4';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('1', 'Red LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='17';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('2', 'Blue LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='18';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('3', 'Green LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='21';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('4', 'LED', '', $now)");
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='22';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('5', 'LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='23';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('6', 'LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='24';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('7', 'LED', '', $now)");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='25';");
			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('8', 'LED', '', $now)");
			mysql_close();
			header('Location: control.php');
		} else IF ($action =="edit"){
			$pin = mysql_real_escape_string($_GET['pin']);
			$query = mysql_query("SELECT pinDescription FROM pinDescription WHERE pinNumber='$pin';");
			$descRow = mysql_fetch_assoc($query);
			$description = $descRow['pinDescription'];
			print '
			<html><head><title>Update Pin ' . $pin . '</title></head><body>
			<table border="0">
			<form name="edit" action="control.php" method="get">
			<input type="hidden" name="action" value="update">
			<input type="hidden" name="pin" value="' . $pin . '">
			<tr>
			<td><p>Description: </p></td><td><input type="text" name="description" value="' . $description . '"></td><td><input type="submit" value="Confirm"></td>
			</tr>
			</form>
			</table>
			</body></html>
			';
			mysql_close();
		} else IF ($action =="update"){
			$pin = mysql_real_escape_string($_GET['pin']);
			$description = mysql_real_escape_string($_GET['description']);
			mysql_query("UPDATE pinDescription SET pinDescription='$description' WHERE pinNumber='$pin';");
			header('Location: control.php');
		} else {
			header('Location: control.php');
		}
	}
} else {
	print '
		<html>
		<head>
		<title>GPIO Control</title>
		</head>
		<font face="verdana">
		<p><h1>Sensors</h1></p>
		';
		$query = mysql_query("SELECT pinNumber, pinStatus FROM pinStatus;");
		$query2 = mysql_query("SELECT pinNumber, pinDescription FROM pinDescription;");
		$totalGPIOCount = mysql_num_rows($query);
		$currentGPIOCount = 0;
		print '<table name="GPIO" border="1" cellpadding="5">';
		print '<tr><th>GPIO #</th><th>GPIO Description</th><th>Status</th><th>Action</th><th>Edit</th></tr>';
		while ($currentGPIOCount < $totalGPIOCount){
			$pinRow = mysql_fetch_assoc($query);
			$descRow = mysql_fetch_assoc($query2);
			$pinNumber = $pinRow['pinNumber'];
			$pinStatus = $pinRow['pinStatus'];
			$pinDescription = $descRow['pinDescription'];
			If ($pinStatus == "0"){
				$buttonValue = "Turn On";
				$action = "turnOn";
				$image = "off.jpg";
			} else {
				$buttonValue = "Turn Off";
				$action = "turnOff";
				$image = "on.jpg";
			}
			print '<tr>';
			print '<td align="center">' . $pinNumber . '</td><td>' . $pinDescription . '</td><td align="center"><img src="' . $image . '" width="50"></td><td align="center" valign="middle"><form name="pin' . $pinNumber . 'edit" action="control.php" method="get"><input type="hidden" name="action" value="' . $action . '"><input type="hidden" name="pin" value="' . $pinNumber . '"><input type="submit" value="' . $buttonValue . '"></form></td><td><form name="pin' . $pinNumber . '" action="control.php" method="get"><input type="hidden" name="action" value="edit"><input type="hidden" name="pin" value="' . $pinNumber . '"><input type="submit" value="Edit"></form></td>';
			print '</tr>';
			$currentGPIOCount ++;
		}
		print '</table>';
		mysql_close();
	print '
	<br><br>
	<a href="control.php?action=logout">Log Out</a>
	</font>
	</html>
	';
}
?>

This is my pinDirection SQL database:


DROP TABLE IF EXISTS `pinDirection`;
CREATE TABLE IF NOT EXISTS `pinDirection` (
  `pinID` int(11) NOT NULL AUTO_INCREMENT,
  `pinNumber` varchar(2) COLLATE utf8_unicode_ci NOT NULL,
  `pinDirection` varchar(3) COLLATE utf8_unicode_ci NOT NULL,
  PRIMARY KEY (`pinID`),
  UNIQUE KEY `pinNumber` (`pinNumber`)
) ENGINE=MyISAM  DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci AUTO_INCREMENT=9 ;

This is my pinStatus SQL database:


DROP TABLE IF EXISTS `pinStatus`;
CREATE TABLE IF NOT EXISTS `pinStatus` (
  `pinID` int(11) NOT NULL AUTO_INCREMENT,
  `pinNumber` varchar(2) COLLATE utf8_unicode_ci NOT NULL,
  `pinStatus` varchar(1) COLLATE utf8_unicode_ci NOT NULL,
  PRIMARY KEY (`pinID`),
  UNIQUE KEY `pinNumber` (`pinNumber`)
) ENGINE=MyISAM  DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci AUTO_INCREMENT=9 ;

This is my sensor SQL database:


CREATE TABLE IF NOT EXISTS `sensor` (
  `id` int(11) NOT NULL,
  `sensor` text NOT NULL,
  `switchOnLog` datetime NOT NULL,
  `switchOffLog` datetime NOT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

Hope you guys could help me out with it as soon as possible, thanks in advance, guys

2

Have you tried tracing through the execution of your PHP code to see where it’s going by adding echo() statements? Sounds crude but can give you an idea of exactly where it is falling over which leads you to why.

Also as someone else will point out, you’d be better not using mysql calls - replace them with mysqli or PDO calls as mysql is on the way to being discontinued.

You seem to have a lot of sections of code like this:


			$dbConnectionSensor = mysql_connect($MySQLHost, $MySQLUserSensor, $MySQLPassword);
			mysql_select_db($MySQLDBSensor, $dbConnectionSensor);
			mysql_query("INSERT INTO sensor('1', 'Red LED', $now, '')");
			mysql_close();
			mysql_query("UPDATE pinStatus SET pinStatus='$setting' WHERE pinNumber='17';");

where it seems that you try to execute a query after you have closed the connection to the database, though I might be remembering mysql incorrectly.