Comments on: A collection is not an array

By: brothercake

brothercake — Fri, 20 Feb 2009 19:51:51 +0000

Why do you care about prototyping to Object, but not to other objects?

By: Juan Mendes

Juan Mendes — Fri, 20 Feb 2009 18:03:06 +0000

A better performance version, push is not very efficient
Note:I don’t care about writing into prototypes except for Object:

  
NodeList.prototype.toArray = function() { 
  var ary = []; 
  for(var i=0, len = this.length; i < len; i++) { 
    ary[i] = this[i]; 
  } 
  return ary; 
};

By: brothercake

brothercake — Wed, 04 Jun 2008 08:49:57 +0000

What can go wrong with the former is the appearance of external prototypes of built-in objects, such as the stuff that the prototype library does. If you have something like this:

Array.prototype.myCustomFunction = function()
{
    ....
}

Then a for..in loop will include that method, because this loop iterates through all properties of an object, where a for loop merely iterates through the numerically-indexed properties (the memebers of an array are merely a subset of its properties, namely, those properties that have a numeric index). The easiest way around that is to use hasOwnProperty to discriminate and ignore the properties you don't want:

for(var i in obj)
{
  if(!obj.hasOwnProperty(i)) { continue; }

  //now we're okay
}

Is that the issue you were referring to?

By: Eric Meyer

Eric Meyer — Sun, 01 Jun 2008 02:35:55 +0000

Is this why doing a for/in loop over a collection causes failures that don’t happen with a straight for loop, and if so, can you explain exactly what goes wrong with the former that isn’t triggered by the latter?

By: brothercake

brothercake — Tue, 25 Mar 2008 23:09:35 +0000

@cranial-bore: you can still bind events to those elements; how you store their references doesn’t affect the elements themselves at all.

@Tino Zijdel: ah yeah, I’d forgotten about that, you can indeed effectively “steal” methods from Array.prototype. Nice :) Dan Webb talks about that in his metaprogramming chapter of Art & Science of JS.

@kyberfabrikken: not sure what you mean there, can you elaborate?

By: kyberfabrikken

kyberfabrikken — Tue, 25 Mar 2008 10:38:24 +0000

A NodeList is a reference to a collection of objects

This is actually a major gotcha — NodeLists are late bound, which can cause quite some confusion, if you iterate over it and manipulate the DOM at the same time. For this reason alone, it’s usually a good idea to convert it into an array.

By: Tino Zijdel

Tino Zijdel — Thu, 20 Mar 2008 14:53:49 +0000

Here’s a nice way to convert a nodeList to an array (it uses the Array.slice() method on the nodeList itself): var nodeArray = [].slice.call(nodeList, 0);

By: cranial-bore

cranial-bore — Thu, 20 Mar 2008 13:21:56 +0000

Thanks for that. I knew a collection wasn’t an array, but I thought that for all intents and purposes they were the same. Good to know what the practical difference really is.

Does this mean that you couldn’t add an event listener to an array element (as per this collection->array function) ?

By: AutisticCuckoo

AutisticCuckoo — Wed, 19 Mar 2008 07:47:40 +0000

Good summary, James! That last point is quite important if you’re dynamically modifying the collection inside a loop.