Comments on: Timing out and retrying calls to third parties

By: timlucas

timlucas — Thu, 24 Aug 2006 00:42:09 +0000

Fenrir2: nice abstraction of my code :)

myrdhrin: In my case I didn’t care watch was being thrown, but might be handier would be if you could pass in a array of exceptions to ignore.

retry_with_timeout(:ignoring => [Timeout::Error, SomeOtherError]) { ... }

There must be a way to make it sexier, say:

3.times { try_with_timeout(5.seconds, :ignoring => SomeOtherError) { ... } }

(the internal timeout should specify and catch its own timeout exception as well as SomeOtherError)

I’ll have a play this evening and see if I can whip that up.

By: myrdhrin

myrdhrin — Wed, 23 Aug 2006 20:48:35 +0000

Fenrir2, instead of catching all the exceptions would you not be better just to catch the Timeout::Error exception?

I mean, if the code in the yield really has a problem you want to know about it…

By: Fenrir2

Fenrir2 — Wed, 23 Aug 2006 18:53:07 +0000

def with_timeout(attempts = 3, timeout = 5)
  attempts.times do
    begin
      Timeout::timeout(timeout) do
        yield
      end
      return true
    rescue Exception
    end
  end
end

with_timeout do
  # ...
end