Comments on: SmartLoader Reloaded

By: Christiaan

Christiaan — Fri, 21 Dec 2007 15:21:51 +0000

Download link still ain’t available, I also would like to try out this new version. Especially since you’ve mentioned the DIRECTORY_SEPERATOR, which probably was why it wasn’t working for me before on Windows.

By: Jann

Jann — Mon, 01 Oct 2007 09:27:03 +0000

Hmm, the download link ist not available anymore, can i get the smartloader update elsewhere?

By: michel

michel — Thu, 28 Sep 2006 15:04:20 +0000

Probably extremely late to the party…

Mincer:
> I found a little ‘quirk’ in the regex pattern,
> in that it matches commented code.

My concern as well, though it’s easily fixed with a little token_get_all(), T_CLASS and T_INTERFACE.

By: Mincer

Mincer — Wed, 24 May 2006 15:45:31 +0000

Oops, let’s try that again….

(why no preview for comments???)

Maarten,

I found a little ‘quirk’ in the regex pattern, in that it matches commented code.

Not only would this be an issue if it thought it could find a class that had been commented out, but also you could inadvertantly overwrite the location of a real class in the index file while writing examples in another file that was scanned elsewhere in the indexing process.

E.g.

File 1:

/**
* FooBar class
*
* Not bothered what I write here, as it’s a comment…
*
* Example Usage:
*
* class MyClass extends FooBar {}
*
*/

File 2:

class MyClass
{
$foo = bar;
}

The index thinks the class can be found in File 1, rather than File 2.

Matt.

By: Mincer

Mincer — Wed, 24 May 2006 15:43:02 +0000

Maarten,

I found a little ‘quirk’ in the regex pattern, in that it matches commented code.

E.g.

File 1:

[code]/**
* FooBar class
*
* Not bothered what I write here, as it's a comment...
*
* Example Usage:
*
* class MyClass extends FooBar {}
*
*/
[/code]

File 2:

[code]class MyClass
{
$foo = bar;
}[/code]

The index thinks the class can be found in File 1, rather than File 2.

Matt.

By: kyberfabrikken

kyberfabrikken — Wed, 19 Apr 2006 21:50:20 +0000

An optimizer might be able fix the loop, but vanilla PHP doesn’t have an optimizer. I always write for-loops as this to be sure :
for ($i=0, $l=count($a); $i < $l; ++$i) { }
Using ++$i rather than $i++ also saves an internal buffer.

By: Maarten Manders

Maarten Manders — Thu, 13 Apr 2006 06:27:01 +0000

mrsmiley, you can easily check that with the following code (or just XDebug/Cachegrind):


for($i = 0; test() && $i < 5; $i++) { /* ... */ }

function test() {
	echo 'Test!
';
	return true;
}

By: mrsmiley

mrsmiley — Thu, 13 Apr 2006 00:40:12 +0000

The sizeof function would be executed for every iteration, which makes a loop about 10x slower than a foreach.

I hope this isn’t the case. I used to think that until I ran some tests a while back and it’s only executed on the first iteration. My test was something like

$test = array(…..);
for ($i=0; $i”prior” to adding more elements inside it.

I believe you only experience said effect while using something like while() and each().

By: mwolfe

mwolfe — Wed, 12 Apr 2006 00:44:05 +0000

sorry
$total = sizeof($array); for($i=0; $i

By: mwolfe

mwolfe — Wed, 12 Apr 2006 00:42:35 +0000

and then there is the obvious performance booster:
$total = sizeof($array);
for($i=0; $i