Comments on: Conditional Class Declaration - bad practice?

By: Winged Spider

Winged Spider — Wed, 31 Dec 1969 19:00:00 +0000

[ot]I can’t view the forum thread you linked to because I don’t have enough permissions?!? Weird…

http://www.sitepoint.com/forums/showthread.php?t=151665/ot

By: George Schlossnagle

George Schlossnagle — Wed, 31 Dec 1969 19:00:00 +0000

I think the real bad practice it protects against is this:

if($day == 'Tuesday') {
class foo {
// class definition ...
}
} else {
class foo {
// something else
}
}

That sort of confitional declaration is much more clearly bad practice, I think.

By: HarryF

HarryF — Wed, 31 Dec 1969 19:00:00 +0000

Not to worry - it was a link to Jason’s member profile in the forums, as opposed to a specific post.

By: Alan Knowles

Alan Knowles — Wed, 31 Dec 1969 19:00:00 +0000

It has been fixed now.. - There where a number of essential examples that used this.. (eg. FC/BC compatiblity on overload stuff)

By: HarryF

HarryF — Wed, 31 Dec 1969 19:00:00 +0000

[QUOTE=Anonymous]I think the real bad practice it protects against is this:

if($day == 'Tuesday') {
class foo {
// class definition ...
}
} else {
class foo {
// something else
}
}

That sort of confitional declaration is much more clearly bad practice, I think.[/QUOTE]

Good point. I guess this is what was being referred to as bad practice.

By: HarryF

HarryF — Wed, 31 Dec 1969 19:00:00 +0000

[QUOTE=Anonymous]It has been fixed now.. - There where a number of essential examples that used this.. (eg. FC/BC compatiblity on overload stuff)[/QUOTE]

Thanks for the update - thats good to hear.