Two same hash function with same values return different outputs

[spaceshiptrooper]

@droopsnoot

Conversely, if the OP has been specifically instructed to hash some strings using the method that they are asking about, it won’t go down well for them to go back to their boss and start telling them about how they have the wrong approach, and refuse to do the work they’ve been assigned unless the boss agrees to do it a different way. Especially if the OP is in a relatively junior position.

True. If the OP has been instructed by their boss to do this kind of exercise then they are in a pickle. However, I don’t think that’s the case. A lot of professional jobs even startups have senior developers. They most certainly wouldn’t be telling junior developers to be doing this kind of exercise. It would be a strange thing to do if it was asked by a senior developer. So, I don’t think it’s the case of professionalism.

What we should really ask is what is this exercise for. Is it for school, work, or for fun.

[Dormilich]

@m_hutley

echo the value. Wrap it in quote marks, for visibility.

better var_dump the value. this comes with the string length included.

[chorn]

@droopsnoot

I understand everyone who is trying to inform the OP on better ways to store passwords, but remember we don’t know the full situation here.

that’s the perfect reason to talk about better concepts, instead of just posting a technical possiblity, imho.

[droopsnoot]

@chorn

that’s the perfect reason to talk about better concepts, instead of just posting a technical possiblity, imho.

I agree, it just seemed in some parts to just be criticising the OP for not wanting to do it the correct way, far beyond the point where that way had been pointed out.

@spaceshiptrooper

What we should really ask is what is this exercise for. Is it for school, work, or for fun.

Yes, and does it even have anything to do with storing passwords for a live system? For all we know, the OP is maybe trying to show why it shouldn’t be done that way.

@spaceshiptrooper

A lot of professional jobs even startups have senior developers. They most certainly wouldn’t be telling junior developers to be doing this kind of exercise.

I guess that depends on whether the senior developer is senior through experience and knowledge, or senior through owning the business or similar. I’d like to think the latter are a dying breed.

[ahundiak]

@patomatsn1

but this code write incorrect hash of passwordlist.txt to hash.txt . i just try to undrestand how can i fix it .

<?php
$passwordFile = fopen("passwords.txt", "r") or die("Unable to open file!");
$hashFile = fopen("hash.txt","w") or die("death to all heretics!");
while($password = fgets($passwordFile))
{
    $password = trim($password);
    if ($password) { // guard against empty lines
        $hash = md5(sha1($password));
        //echo $hash . "\n";
        fputs($hashFile,$hash . "\n");
    }
}
fclose($hashFile);
fclose($passwordFile);