Slideshow doesn't work when placed inside a MC

Content
1

How come the following AS3 works fine when placed in Scene 1, but throws multiple “1120 Access of undefined property” errors when the code is placed inside a movie clip?
Somehow none of the variables in the code are recognized in the later case.

Cheers


function loadXML(loaded) {

	if (loaded) {

		xmlNode = this.firstChild;
//		xmlNode = parent.firstChild;
		image2 = [];
		description = [];
		total = xmlNode.childNodes.length;
		for (k=0; k<total; k++) {

			image2[k] = xmlNode.childNodes[k].childNodes[0].firstChild.nodeValue;
			description[k] = xmlNode.childNodes[k].childNodes[1].firstChild.nodeValue;
		}
		firstImage();
	} else {

		content = "file not loaded!";
	}
}

xmlData2 = new XML();
xmlData2.ignoreWhite = true;
xmlData2.onLoad = loadXML;
xmlData2.load("images.xml");
/////////////////////////////////////
listen = new Object();
listen.onKeyDown = function() {

	if (Key.getCode() == Key.LEFT) {

		prevImage();
	} else if (Key.getCode() == Key.RIGHT) {

		nextImage();
	}
};

Key.addListener(listen);
previous_btn.onRelease = function() {

	prevImage();
};

next_btn.onRelease = function() {

	nextImage();
};
/////////////////////////////////////

p = 0;
this.onEnterFrame = function() {

	filesize = picture.getBytesTotal();
	loaded = picture.getBytesLoaded();
	preloader._visible = true;
	if (loaded != filesize) {

		preloader.preload_bar._xscale = 100*loaded/filesize;
	} else {

		preloader._visible = false;
		if (picture._alpha<100) {
			picture._alpha += 10;
		}
	}
};

function nextImage() {

	if (p<(total-1)) {

		p++;
		if (loaded == filesize) {
			picture._alpha = 0;
			picture.loadMovie(image2[p], 1);
			desc_txt.text = description[p];
			picture_num();
		}
	}
}

function prevImage() {

	if (p>0) {

		p--;
		picture._alpha = 0;
		picture.loadMovie(image2[p], 1);
		desc_txt.text = description[p];
		picture_num();
	}
}

function firstImage() {

	if (loaded == filesize) {

		picture._alpha = 0;
		picture.loadMovie(image2[0], 1);
		desc_txt.text = description[0];
		picture_num();
	}
}

function picture_num() {

	current_pos = p+1;
	pos_txt.text = current_pos+" / "+total;
}
2

That code is AS2 not 3

3

Hi EastCoast,

Thanks for your response to my query.
Fair enough, I cannot argue with that.
I’ve replaced the piece of AS2 with AS3 code.

However, embedding it into my Flash file is an issue. I’m getting no compiler errors, but when I click on a MC panel to load a slideshow I get the following output error messages:

TypeError: Error #1010: A term is undefined and has no properties.
at mainCS3_final11_fla::MainTimeline/addFullPanel()
at mainCS3_final11_fla::mainContainer_1/onClick()

The slideshow AS within the FullProjectPanel MC reads:


stop();

var galleryData:XML;

var galleryLoader:URLLoader = new URLLoader();
galleryLoader.addEventListener(Event.COMPLETE, onGalleryDataLoaded, false, 0, true);

var panelNames:String = MovieClip(this.parent).name;

trace("trace.this = "+this);
trace("trace.this.parent = "+this.parent);
trace("panel chosen (outside function) = "+panelNames);

switch(panelNames) {

    case "pic1.jpg":
    //case "instance49":
    trace("panel chosen = "+panelNames);
    galleryLoader.load(new URLRequest("gallery1.xml"));
    break;

    case "pic2.jpg":
    galleryLoader.load(new URLRequest("gallery2.xml"));
    break;
    
    case "pic3.jpg":
    galleryLoader.load(new URLRequest("gallery3.xml"));
    break;

    case "pic4.jpg":
    galleryLoader.load(new URLRequest("gallery4.xml"));
    break;

    case "pic5.jpg":
    galleryLoader.load(new URLRequest("gallery5.xml"));
    break;
}

function onGalleryDataLoaded(evt:Event):void {

    galleryData = new XML(evt.target.data);
    // start checking if the movie is loaded
    addEventListener(Event.ENTER_FRAME, onCheckLoaded, false, 0, true);
    galleryLoader.removeEventListener(Event.COMPLETE, onGalleryDataLoaded);
}

function onCheckLoaded(evt:Event):void {

    if (root.loaderInfo.bytesTotal == root.loaderInfo.bytesLoaded) {

        gotoAndStop("main");
        removeEventListener(Event.ENTER_FRAME, onCheckLoaded);
    }
}

Depending on what MC I click, the script should load a corresponding slideshow.
On Scene 1 I’ve got:


import com.greensock.TweenLite;
import com.greensock.easing.Back;

import com.greensock.loading.*;
import com.greensock.loading.display.*;
import com.greensock.events.LoaderEvent;

import flash.display.Sprite;
import flash.text.*;

import flash.display.BitmapData;
import flash.display.Bitmap;

// CONTAINER FOR SCROLLING
var panelContainer:Sprite = new Sprite;
addChild(panelContainer);

// INITIAL VARIABLES

var imageArray:Array = new Array();
var currentButton:Object = new Object;
var selectedSection:Number = 0;
var myThumb:Array = new Array();
var myImage:Array = new Array();

function progressHandler(event:LoaderEvent):void {
    trace("progress: " + event.target.progress);
}

//loader.contentLoaderInfo.addEventListener(ProgressEvent.PROGRESS, loadProgress);

function loadProgress(event:ProgressEvent):void {  
    var percentLoaded:Number = Math.ceil(event.bytesLoaded/event.bytesTotal); 
    trace("Loading: "+percentLoaded+"%");  
}  

var xmlLoader:URLLoader = new URLLoader();
var xmlData: XML;

//Load the XML file
xmlLoader.load(new URLRequest("images/slides2.xml"));

//Adding an event listener to notify when loading is completed
xmlLoader.addEventListener(Event.COMPLETE,ParseXML);

function ParseXML(event:Event):void {

    var panelArray:Array = new Array();
    xmlData = new XML(event.target.data);
    var lengthDoc = xmlData.image.name.length();
    
    for (var j:int=0; j<lengthDoc; j++) {

        var xmlLoader = new Loader();
        var panelItem:ProjectPanel = new ProjectPanel;
        var imageName = (xmlData.image[j].name);
        panelItem.name = imageName;

        panelItem.addEventListener(MouseEvent.CLICK, onClick);
        panelItem.buttonMode = true;
        panelItem.project_title.text = (xmlData.image[j].description.@title);
        panelItem.project_description.text = (xmlData.image[j].description);

        var imageThumb:String = xmlData.image[j].path.@thumb.toString();
        var imageLarge:String = xmlData.image[j].path.@large.toString();
        myThumb[j] = imageThumb;
        myImage[j] = imageLarge;
        trace (myImage[j]);
        var imageUrlRequest:URLRequest = new URLRequest(myThumb[j]);
        imageArray[j] = xmlLoader.load(imageUrlRequest);
        imageArray.push(xmlLoader);
        panelItem.project_image.MovieClip = (imageArray[j+1]);
        panelItem.project_image.addChild(imageArray[j+1]);

        if (j>0) {

            panelItem.x = j*(panelArray[j-1].width+10);
        }
        panelArray.push(panelItem);
        // adding Items as children to Container
        panelContainer.addChild(panelItem);
    }
}

function ParseXML2(imageData2:XML):void {

    trace("------------------------");
    trace("XML Output");
    trace("------------------------");
     
    var imageChildren:XMLList = imageData2.image.children();
     
    for each (var imageData2:XML in imageChildren) {
        if (imageData2.name() == "name") {
        }
    }
}

function errorHandler(event:LoaderEvent):void {
    trace("error occured with " + event.target + ": " + event.text);
}

function onClick(evt:MouseEvent) {

    // tween all panels below visible area when clicking on projectPanel
    TweenLite.to(panelContainer, 0.5, {y:stage.stageHeight+250, ease:Back.easeIn});

    var target:MovieClip = evt.currentTarget as MovieClip;
    var panelNames:String = target.name;
    trace("panel chosen (inside function) = "+panelNames);
    MovieClip(this.parent).addFullPanel(panelNames);
    // running function on the main timeline
}

// slide the panels back up on closing the single panel project
function slideUp():void {
    
    TweenLite.to(panelContainer, 0.5, {y:0, ease:Back.easeOut});
}

// HORIZONTAL SCROLLING 
stage.addEventListener(MouseEvent.MOUSE_MOVE, onMove);

function onMove(evt:MouseEvent):void {

    // scroll only if fullprojectpanelup is false to prevent from interfering with transitions
    if (MovieClip(this.parent).fullProjectPanelUp==false) {

        TweenLite.to(panelContainer, 0.3, {x:-(stage.mouseX/980)*panelContainer.width+stage.stageWidth/2});
    }
}

stop();

And on Scene1 on the main Timeline I’ve got:


import com.greensock.TweenLite;

var fullProjectPanel: FullProjectPanel;

function loadProgress(event:ProgressEvent):void {

    var percentLoaded:Number = event.bytesLoaded/event.bytesTotal;
    percentLoaded = Math.round(percentLoaded * 100);
    trace("Loading: "+percentLoaded+"%");
}

function loadComplete(event:Event):void {

    trace("Complete");
}

var loader:Loader = new Loader();
loader.contentLoaderInfo.addEventListener(ProgressEvent.PROGRESS, loadProgress);
loader.contentLoaderInfo.addEventListener(Event.COMPLETE, loadComplete);

// ADD FULL PROJECT PANEL ( runs when clicking on project panel(2nd frame of mainContainer, line 28))

function addFullPanel(panelNames:String) {

    var path:String = "images/"+panelNames;
    fullProjectPanel = new FullProjectPanel();
    var request:URLRequest = new URLRequest(path);
    loader.load(request);
    trace("path = "+path);

    TweenLite.from(fullProjectPanel, 0.6, {alpha:0, delay:0.5});
    addChild(fullProjectPanel);

    // indicate state
    fullProjectPanelUp = true;

    // listen for click on close button
    fullProjectPanel.closePanel.addEventListener(MouseEvent.CLICK, onCloseClick);
    fullProjectPanel.closePanel.buttonMode = true;
}

function onCloseClick(evt:MouseEvent):void {

    // run the slide up function that slides up the project container 
    mainContainer.slideUp();

    // remove the panel
    removeChild(fullProjectPanel);

    // delay the state change to allow for transition
//  TweenLite.delayedCall(0.4, upFalse);
}

function upFalse():void {
    
    fullProjectPanelUp = false;
}

Using the trace command, I think I managed to track down the source of the issue. The variable panelNames exists only within the function.
In other words

trace (panel chosen (inside function)) = pic1.jpg

which is correct, and

trace (panel chosen (outside function) = root1.

So when I use the switch function in the FullProjectPanel MC it doesn’t recognize the panelNames anymore. Do I have to define panelNames globally, and if so how do I go about doing that? Or is there a more trivial solution?

Hope someone can point me in the right direction.

Cheers