Php values not recognisd

PHP
1

Hi,

I have built a form whereby i use it to upload image files which is then to be stored on my server and it's information e.g description of image, to be saved on my mysql db. I am having trouble with php not recognisiing my 'photo' variable as it is giving me the following error when i submit my form:

Notice: Undefined index: photo in C:\\wamp\\www\\Shanghai2010\\index.php on line 50

Notice: Undefined index: photo in C:\\wamp\\www\\Shanghai2010\\index.php on line 51

along with my user generate error:


Database error storing file information

When i submit the form the image is stored successfully on my server, but the information relating to the image is not stored.

imageuploadform.html


<body>
    <form enctype="multipart/form-data" action=" " method="post">        
        <div>
        <label for="description"> Description: </label> <input type="text" name="description" id="description" /> <br >
        </div>
        
        <div>
            <label for="category"> Category </label>
            <select name="category" id="category">
                    <option value="Cheng_Huang_Temple">Cheng Huang Temple </option>
                    <option value="Shanghai_Zoo">Shanghai Zoo </option>
            </select> <br />
        </div>
        
        <div>
            <label for="uploadimg"> Upload Photo: </label>
         <input type="file" id="photo" name="photo" value="photo/> <br >
        </div>
        
        <div>
        <input type="hidden" name="action" value="upload" />
        <input type="submit" value="Upload" />
        </div>
    </form>
    
 </body>

index.php code snippet:



if(move_uploaded_file($_FILES['photo']['tmp_name'],$target))
      { 
          // Get information from the form
          $uploaddesc = $_POST['photo']['description'];
          $uploadcat = $_POST['photo']['category']; // error referring to this 
          $uploadname = $_FILES['photo']['tmp_name']; // error referring to this
          
           
          // Prepare for user submitted for safe database insert
          $uploaddesc = mysqli_real_escape_string($link, $uploaddesc);
          $uploadcat = mysqli_real_escape_string($link, $uploadcat);
          $uploadname = mysqli_real_escape_string($link, $uploadname);
          
         include $_SERVER['DOCUMENT_ROOT'] . '/includes/shanghai_db.inc.php';
          $sql = mysqli_query($link, "INSERT INTO  image_detail SET Filename = '$uploadname',
                              Category = '$uploadcat', Description = '$uploaddesc'");
          
          if(!mysqli_query($link, $sql) )
          {
            $error = 'Database error storing file information';
            include 'error.html.php';
            exit();
          }
          else
          {
            
            $output = 'The file and information has been stored successfully';      
          }
           include 'success.html.php';
      }

Why does it say that error because in my html form i also added the value=“photo” but no luck

2

Because you save the temp file name in the database, and not the target file name :shifty:

3

and why on my db column name, Filename says the location to be: C:\wamp\ mp\php5F67.tmp because when i go to C:\wamp\www\Shanghai2010\images\ i can see my image file there, why does it say differente?

4

Anybody know why it goes into my generate error?

5

Perhaps try this, maybe the file isn’t moving to the right place:


if(move_uploaded_file($_FILES['photo']['tmp_name'],$target))
// All your stuff in here..
}
## Add this line below the IF statement
else {
  die("Error moving file");
}

By the way, you always want to do
$_POST[‘name_of_field’],
$_FILE[‘name_of_field’],

The difference is that $_FILE generates a multi-dimensional array containing the data of the upload…
That’s why it’s $_FILE[‘name_of_field’][‘name’]; and so on
You can see all the information by doing print_r($_FILE);

6

If i change it, if for example i were to write the column names wrong perhaps, it would natuarlly go into my error state wouldn’t it?

7

I removed the value attribute on my form and made the adjustment to my php file. After i submitted the form it goes into a blank screen and the details of my image are not saved onto my db, also the image is not saved onto my server. I initially thought by having the following:

$uploaddesc = $_POST[‘photo’][‘description’];
$uploadcat = $_POST[‘photo’][‘category’];

would have worked because i’m using the book, Build Your Own Database Driven Website by Kevin Yank 4th Edition, Chapter 12, filestore to help me do this which seemed to work in the book’s tutorial. So i don’t know why i had to change it

$uploaddesc = $_POST[‘description’];
$uploadcat = $_POST[‘category’];

Why does the info and image file not save on my server and my db after the resulting changes?

8 
<input type="file" id="photo" name="photo" value="photo/>

Needs to be

<input type="file" id="photo" name="photo" />

You can’t set a file value, it’s a security risk and as far as I’m aware it doesn’t work in browsers.

9

Change


$sql = mysqli_query($link, "INSERT INTO  image_detail SET Filename = '$uploadname',
                    Category = '$uploadcat', Description = '$uploaddesc'");

into


$sql = "
  INSERT INTO  image_detail 
  SET Filename = '$uploadname',
        Category = '$uploadcat', 
        Description = '$uploaddesc'
";

The query itself gets executed in the if.

10

ah i see right, i changed the tmp_name to name, so when i ran it i saw the image name on my db side, however, the php script keeps going into my


 if(!mysqli_query($link, $sql) )
          {
            $error = 'Database error storing file information';
            include 'error.html.php';
            exit();
          }

state and not into my


 else
          {
            
            $output = 'The file and information has been stored successfully';      
          }
           include 'success.html.php';
      }

state because on the db side, it looks fine and on my server side, the image is saved there successfully. Why does it still gointo my erro state?

11

Interesting indeed, after adding the else statement, and not really changin the ‘If’ part, i ran my app again, submitted the file and added it’s information accordingly. It was able to save my file onto the server into the correct location, on my db side, the information was saved successfully, however, on the column ‘Filename’ the value for this is:C:\wamp\ mp\php5F67.tmp. Now, the file name is obviously different to that of my image which i’m curious to know, is this got to do with how PHP uses the tmp_name?

Also, on my browser, i get my user generated error: Database error storing file information
which i am guessing has to do with the filename as it does not output my



 $output = 'The file and information has been stored successfully';      
          }
           include 'success.html.php';
.....

section. Here is what my IF statement looks liken now with updated changes:


 if(move_uploaded_file($_FILES['photo']['tmp_name'],$target))
      { 
          // Get information from the form
          $uploaddesc = $_POST['description'];
          $uploadcat = $_POST['category']; 
          $uploadname = $_FILES['photo']['tmp_name'];            
           
           //Prepare for user submitted for safe database insert
          $uploaddesc = mysqli_real_escape_string($link, $uploaddesc);
          $uploadcat = mysqli_real_escape_string($link, $uploadcat);
          $uploadname = mysqli_real_escape_string($link, $uploadname);
          
         include $_SERVER['DOCUMENT_ROOT'] . '/includes/shanghai_db.inc.php';
          $sql = mysqli_query($link, "INSERT INTO  image_detail SET Filename = '$uploadname',
                              Category = '$uploadcat', Description = '$uploaddesc'");
          
          if(!mysqli_query($link, $sql) )
          {
            $error = 'Database error storing file information';
            include 'error.html.php';
            exit();
          }
          else
          {
            
            $output = 'The file and information has been stored successfully';      
          }
           include 'success.html.php';
      }
      else
      {
        die("Error moving file");
      }
12

Change


$uploaddesc = $_POST['photo']['description'];
$uploadcat = $_POST['photo']['category']; // error referring to this

into


$uploaddesc = $_POST['description'];
$uploadcat = $_POST['category'];