PHP MySQL novice to ninja 6th edition – Sessions-Logout

[dmitrijs63]

Hi!
The code of the project in the commit Sessions-Logout (https://github.com/spbooks/phpmysql6/tree/Sessions-Logout) has a bug, because the logout functionality doesn’t work correctly – it is still possible to edit / add / delete the jokes after logging out?

Can anybody explain where is the bug.

Thanks

[rpkamp]

@dmitrijs63

because the logout functionality doesn’t work correctly

How does it not work? What was the expected behaviour and what do you see instead? Any error message or other relevant log messages etc?

[m_hutley]

I am eventually going to be compelled to buy this book just to be able to answer questions about it, but i’m fairly sure the answer to

@dmitrijs63

it is still possible to edit / add / delete the jokes after logging out?

is ‘true, but this isnt the final form of the code either, so… keep reading’?

[dmitrijs63]

@rpkamp

How does it not work? What was the expected behaviour and what do you see instead? Any error message or other relevant log messages etc?

After logging out it is still possible to edit, add and delete jokes

[Mittineague]

What does your Controllers/Login.php file look like?

Updated login.php to fix logout issue

[m_hutley]

@Mittineague (I assume, without the book, that) it’s more that the lesson is about logging people out, not securing the other pages against non-logged-in people. There are no controls (at this point in the book) on add/edit/delete jokes to ensure a user is logged in.

It’s a logical concern, but not the point of the lesson. I assume that @TomB goes on from this lesson to explain what you should DO when someone is not logged in and attempts to access the functions that only logged in people are meant to access.

I’ll also be honest and trying to find anything in this design paradigm is confusing me to the ends of the earth and very difficult to follow the flow, so perhaps i’m mistaken.

[dmitrijs63]

Mittineague, thank you very much!

[TomB]

as Mittineague says, this was fixed in the code in the book, and in the the code, unfortunately it wasn’t applied to all the relevant branches.

@m_hutley

I am eventually going to be compelled to buy this book just to be able to answer questions about it

If you’re browsing the forums there’s an advert to get it for free, so you should just be able to enter your email and get a copy I’m not sure if I’m seeing that advert because my account is flagged as an author though.

[droopsnoot]

@TomB

If you’re browsing the forums there’s an advert to get it for free,

I see that from time to time, though I seem to recall when I tried it, it rejected my email for some reason. If it pops up again, I’ll try it and provide more detail somewhere if it fails.