PHP and MYSQL - How to write the OR

PHP
1

Can someone please help.
I want to use an OR statement but not sure how it should look in my function.

public static function getMessage($code) {
$db = Db::getInstance();

$query = "SELECT * " .
"FROM " . TBL_MAINTEXT . " WHERE ".
" from_datetime <= NOW() “.
" AND to_datetime >= NOW() " .
" AND code = '” . $db->escape_string($code) . "’ " .

		      " OR " .
		      " start_time &lt;= CURTIME() ".
		      " AND end_time &gt;= CURTIME() " .
		      " AND message_type = 'DAILY' "
		      
		      " OR " .
		      " start_time &lt;= CURTIME() ".
		      " AND end_time &gt;= CURTIME() " .
		      " AND message_day = DAYOFWEEK(NOW()) " .
		      " AND message_type = 'WEEKLY' " .
		      
		      " OR " .
		       " start_time &lt;= CURTIME() ".
		      " AND end_time &gt;= CURTIME() " .
		      " AND message_day = DAYOFMONTH(CURRENT_DATE)"
		      " AND message_type = 'MONTHLY' " .
		      
		      " OR " .
		      " message_default = 'Y' "
		      " ORDER BY message_default ACE Limit 1";

Thanks for your help in advance

2

It depends on what you want to achieve. But looking at your query, I guess this should work:


SELECT 
   specify fields here instead of using * 
FROM " . TBL_MAINTEXT . " 
WHERE 
  (    from_datetime <= NOW() 
   AND to_datetime >= NOW() 
   AND code = '" . $db->escape_string($code) . "'
  )
OR 
  (    start_time <= CURTIME() 
   AND end_time >= CURTIME() 
   AND message_type = 'DAILY' 
  )
OR
  (    start_time <= CURTIME() 
   AND end_time >= CURTIME() 
   AND message_day = DAYOFWEEK(NOW()) 
   AND message_type = 'WEEKLY' 
  )
OR
  (    start_time <= CURTIME() 
   AND end_time >= CURTIME() 
   AND message_day = DAYOFMONTH(CURRENT_DATE)
   AND message_type = 'MONTHLY' 
  )
OR 
  (   message_default = 'Y' 
  )
ORDER BY message_default  
Limit 1
3

Also, a tip: You don’t have to concatenate multiple-line strings. Your code will be much easier to read this way:

$query = "SELECT * 
FROM " . TBL_MAINTEXT . " WHERE 
 from_datetime <= NOW() 
 AND to_datetime >= NOW() 
 AND code = '" . $db->escape_string($code) . "' 
 OR 
 start_time <= CURTIME()
 AND end_time >= CURTIME() 
 AND message_type = 'DAILY'
 OR 
 start_time <= CURTIME() 
 AND end_time >= CURTIME() 
 AND message_day = DAYOFWEEK(NOW()) 
 AND message_type = 'WEEKLY'
 OR
 start_time <= CURTIME()
 AND end_time >= CURTIME()
 AND message_day = DAYOFMONTH(CURRENT_DATE)
 AND message_type = 'MONTHLY' 
 OR 
 message_default = 'Y' 
 ORDER BY message_default ACE Limit 1";
4

Thanks so much

5

Could also condense the start_time / end_time checks out of two of the clauses, but yeah.