My first HTML&CSS try – need review

[B]this is my first try to do some thing using what i learned in HTML&CSS

it is like Facebook cover & profile picture part

so please review my code

i hope you give your comments & suggestions to improve my self

this is my code

[URL=“https://gist.github.com/HeshamGhoniem/b324b4323516afbd1392”]click here

and this is a preview of what i do

Click here[/B]

Hi, Hesham. Welcome to the forums. :slight_smile:

A quick glance at your code leaves me with the following impressions.

(1) It’s very organized and neatly written. That is a bonus for anyone helping you, as well as a year from now when you try to remember how all those styles play together. Organized, structured code is easier to read.

(2) Using absolute positioning for layout should be reserved to those occasions when it is absolutely necesssary. If you increase the size of the font only, you will find that the buttons overlap because they are NOT designed to “go with the flow” of the page. I suggest that you read-up on other methods of placing things on a page.

(3) I would encourage you to use classes instead of IDs unless an ID is necessary. IDs are sometimes needed by JavaScript and ID’s are needed for on-page targets for anchors using fragment identifiers. You will avoid some specificity headaches by minimizing the use of IDs.

Personally, I think you’re off to a good beginning; but I’m partial to human-readable code like yours. :slight_smile:

For an advanced head start, please read the stick thread at the top of this forum:
http://www.sitepoint.com/forums/showthread.php?171943-CSS-FAQ-Tips-etc-Please-read-before-posting!

If you have more specific questions or concerns about particular coding issues, feel free to ask.

thanks very much ronpat for your review & comments

great Tips for me :slight_smile: