Keep getting invalid email

PHP
1

OK, I have a routine (taken from the web) that SHOULD validate a valid email address (using info@saccc567.com which is valid). But, it keeps returning FALSE so I get the message “Invalid email” and exits out (per my check)

Here is my php code:


<?php
function is_valid_email($email) {

   $isValid = true;
   $atIndex = strrpos($email, "@");
   if (is_bool($atIndex) && !$atIndex)
   {
      $isValid = false;
   }
   else
   {
      $domain = substr($email, $atIndex+1);
      $local = substr($email, 0, $atIndex);
      $localLen = strlen($local);
      $domainLen = strlen($domain);
      if ($localLen < 1 || $localLen > 64)
      {
         // local part length exceeded
         $isValid = false;
      }
      else if ($domainLen < 1 || $domainLen > 255)
      {
         // domain part length exceeded
         $isValid = false;
      }
      else if ($local[0] == '.' || $local[$localLen-1] == '.')
      {
         // local part starts or ends with '.'
         $isValid = false;
      }
      else if (preg_match('/\\\\.\\\\./', $local))
      {
         // local part has two consecutive dots
         $isValid = false;
      }
      else if (!preg_match('/^[A-Za-z0-9\\\\-\\\\.]+$/', $domain))
      {
         // character not valid in domain part
         $isValid = false;
      }
      else if (preg_match('/\\\\.\\\\./', $domain))
      {
         // domain part has two consecutive dots
         $isValid = false;
      }
      else if
(!preg_match('/^(\\\\\\\\.|[A-Za-z0-9!#%&`_=\\\\/$\\'*+?^{}|~.-])+$/',
                 str_replace("\\\\\\\\","",$local)))
      {
         // character not valid in local part unless 
         // local part is quoted
         if (!preg_match('/^"(\\\\\\\\"|[^"])+"$/',
             str_replace("\\\\\\\\","",$local)))
         {
            $isValid = false;
         }
      }
      if ($isValid && !(checkdnsrr($domain,"MX") || checkdnsrr($domain,"A")))
      {
         // domain not found in DNS
         $isValid = false;
      }
   }
   return $isValid;

}
?>

Can’t figure out why the valid email is being tagged invalid. Or maybe just don’t understand what is going on with this - I am still new at PHP so…

Thanks

F

2

put some echo statements (just for debugging purposes) in that function to see where the email is being tagged invalid

3

There’s always [fphp]filter_var[/fphp]. :wink:

<?php
function is_valid_email($email){
  return false !== filter_var($email, FILTER_VALIDATE_EMAIL);
}
4

Ah… figured it out thanks to the reminder from guido2004 - have to do more debugging and forgot about echoing the stuff back to see what is going on. Thanks.

Anthony, the filter works - kind of. It allows too much through so am trying other things. I thought it was too simple - and it should be.

Thanks to both of you for putting me on the right track.

F