jQuery Validate: Don't allow Gmail, Yahoo, etc email addresses

[ripcurlksm]

I’ve got the jQuery validate script working, and I’ve added (found) a function to prevent anyone from registering a free email (Yahoo, Gmail, etc.) but the validation is not working and is letting any email address be submitted. Any idea?

$(document).ready(function() {
    
$.validator.addMethod('nofreeemail', function (value) { 
    return /^([w-.]+@(?!gmail.com)(?!yahoo.com)(?!hotmail.com)([w-]+.)+[w-]{2,4})?$/.test(value); 
}, 'Free email addresses are not allowed.');
        
// validate signup form on keyup and submit
        $("#registerform").validate({
            rules: {
                username: {
                    required: true,
                    minlength: 2,
                    nofreeemail: true
                },
                password: {
                    required: true,
                    minlength: 5
                }    
            },
            messages: {
                username: {
                    required: "Please enter a username",
                    minlength: "Your email must consist of at least 2 characters",
                    nofreeemail: "Please use your business email, we don't accept Gmail, Yahoo, Hotmail accounts."
                },
                password: {
                    required: "Please provide a password",
                    minlength: "Your password must be at least 5 characters long"
                }
            }
        });
});

[fretburner]

Your regex is missing some backslashes to escape the periods in the domain names and the word matchers (\w):

return /^([\w-.]+@(?!gmail\.com)(?!yahoo\.com)(?!hotmail\.com)([\w-]+.)+[\w-]{2,4})?$/.test(value);

[ripcurlksm]

Brilliant, thank you fretburner! I have a working test page up here, and one last weird behavior I am seeing now is if you enter an invalid email like “asdf” and move on to the password, its not telling the user to enter a valid email, its saying to enter a non google, yahoo, etc email.

Click here and type in ‘asdf’ as the email and its not warning the user the email is invalid
http://ksm.fm/misc/emailvalidation.php

[felgall]

@fretburner

{2,4}

I’d suggest getting rid of the 4 - there are lots of valid top level domains now that have more than four letters. One they have been promoting around here lately is .sydney (six letters after the dot)

[ripcurlksm]

So this?
return /^([\w-.]+@(?!gmail.com)(?!yahoo.com)(?!hotmail.com)([\w-]+.)+[\w-]{2})?$/.test(value);

Also can you help me on my last post in this thread above yours?

[felgall]

@ripcurlksm

So this?

No. You now are restricting it to just two characters after the last dot - you need the comma after the 2.

@ripcurlksm

its not telling the user to enter a valid email, its saying to enter a non google, yahoo, etc email.

So the validation order is wrong and you are testing for not a free email address first before testing for a valid email address. The regular expression you are using checks for both so if it isn’t a valid email address then it fails the test just as it would if it were a free address.

[ripcurlksm]

hey felgall, long time since ive seen your avatar! That makes sense, thank you!