How to solve the $sql with words to search in a loop

PHP
1

I put together in a testpage what’s causing the error. I have 3 pages (includefiles) into one which searches words in the database. It’s not a php error.

It’s just that for some reason $sql doesn’t forget the previous results and on the second page’s code it adds the previous pages results. And on the 3rd page it adds the previous 2 pages’ results.

I have the php file but it links to my db tables which are long. I could probably give you my html file with my php.

overviewtestpage.php (32.8 KB)

overviewtestpage.html (42.1 KB)

2

I had a bit of a look through the PHP code but I’m struggling to follow where it’s going. I get that you’ve merged three files into one, but I can’t follow where it calls from the first page to the second to the third. Do you mean page in the sense of paginated results, or something else?

3

No. Loof at the $sql s echoed on the page. The result of the $sql s add from the previous $sql s. Look at the verse numbers how they repeat in the following one.

4

Looking at one section of your code, you build two queries in variables $sql9a and $sql9b, then you execute them:

	// Step 3: Send the query
		$result9a = $db->query($sql9a);
		$result9b = $db->query($sql9b);

and then you loop through each result set $result9a and $result9b to build the arrays. However, the PDO doc for query() says : "If you do not fetch all of the data in a result set before issuing your next call to PDO::query(), your call may fail. " which I read as suggesting that once you’ve run a query you need to get the results and work with them, not run another query.

It should be quite straightforward to move the second query to execute after you’ve handled the results for the first one, to see if it helps.

5

Well the thing is the page is actually include files of queries. How am i supposed to go through all that then?

I set a sample page above of 3 queries.

THis is what I expect:
overviewtestpage-shouldbe.html (29.4 KB)

6

Step by step until you find the problem, same as everyone else does.

You do also seem to go through the same loop more than once, building the arrays each time. If you look at the two queries I mentioned above which are on lines 624 and 625 in the php code, they build up arrays ending in 9a and 9b (and some others) in the following piece of code. Then in 768 and 769, having built another two queries, you then run them and add the results to the same array names. Then again in 920/921, and add the results to the same arrays. I can’t see anywhere that you’ve emptied those arrays between execution.

I know you’ve merged separate files into one, but if you’re only including them and the separate loops are not surrounded by if()s and really execute in the sequence of the overview, I can’t see how the second and third queries would do anything other than append to the same arrays.

7

how do i empty the arrays then?

8

Ok I answer my own question (thanks for pointing it out!):
$id9a = Array(); //[‘id’];
$bookSpoke9a = Array(); //[‘book_spoke’];
$chapterSpoke9a = Array(); //[‘chapter_spoke’];
$verseSpoke9a = Array(); //[‘verse_spoke’];
$bookTitle9a = Array(); //[‘book_title’];
$book9a = Array(); //[‘book’];
$chapter9a = Array(); //[‘chapter’];
$verse9a = Array(); //[‘verse’];
$recordType9a = Array(); //[‘recordType’];
$textData9a = Array(); //[‘text_data’];
$bSpokeCycle9a = Array(); //[‘b_spoke_cycle’];
$cSpokeCycle9a = Array(); //[‘c_spoke_cycle’];
$vSpokeCycle9a = Array(); //[‘v_spoke_cycle’];

        $id9b = Array(); //['id'];
        $bookSpoke9b = Array(); //['book_spoke'];
        $chapterSpoke9b = Array(); //['chapter_spoke'];
        $verseSpoke9b = Array(); //['verse_spoke'];
        $bookTitle9b = Array(); //['book_title'];
        $book9b = Array(); //['book'];
        $chapter9b = Array(); //['chapter'];
        $verse9b = Array(); //['verse'];
        $recordType9b = Array(); //['recordType'];
        $textData9b = Array(); //['text_data'];
        $bSpokeCycle9b = Array(); //['b_spoke_cycle'];
        $cSpokeCycle9b = Array(); //['c_spoke_cycle'];
        $vSpokeCycle9b = Array(); //['v_spoke_cycle'];
9

I think you might need to destroy them first:

unset($id9b);
$id9b = array();

and so on. Or if there’s only ever going to be those three loops, use different array names in each one.

1 Like
10

This topic was automatically closed 91 days after the last reply. New replies are no longer allowed.