How come add and subtract are not working in this code?

JavaScript
1

Only multiply and divide work.

https://jsfiddle.net/vmfurgpz/

function multiplyBy() {
  num1 = document.getElementById("firstNumber").value;
  num2 = document.getElementById("secondNumber").value;
  document.getElementById("result").innerHTML = num1 * num2;
}

function divideBy() {
  num1 = document.getElementById("firstNumber").value;
  num2 = document.getElementById("secondNumber").value;
  document.getElementById("result").innerHTML = num1 / num2;
}


function subtractBy() {
  num1 = document.getElementById("firstNumber").value;
  num2 = document.getElementById("secondNumber").value;
  document.getElementById("result").innerHTML = num1 / num2;
}

function addBy() {
  num1 = document.getElementById("firstNumber").value;
  num2 = document.getElementById("secondNumber").value;
  document.getElementById("result").innerHTML = num1 / num2;
}
2

I think you cut and pasted the above line but forgot to alter the mathematical operator

3

Neither addBy() nor subtractBy() are adding or subtracting. Both are also dividing.

4

How do I fix it?

5

function subtractBy() {
num1 = document.getElementById(“firstNumber”).value;
num2 = document.getElementById(“secondNumber”).value;
document.getElementById(“result”).innerHTML = num1 / num2;

What is the red section supposed to be doing.
I’m starting to suspect you’re just fishing for people to do your homework at this point…

6

addBy isn’t working, how come?
https://jsfiddle.net/7d542bhf/1/

function addBy() {
  num1 = document.getElementById("firstNumber").value;
  num2 = document.getElementById("secondNumber").value;
  document.getElementById("result").innerHTML = num1 + num2;
}
7

num1 and num2 are strings.

Use:

function addBy() {
  num1 = parseFloat(document.getElementById("firstNumber").value);
  num2 = parseFloat(document.getElementById("secondNumber").value);
  document.getElementById("result").innerHTML = num1 + num2;
}
1 Like
8

This topic was automatically closed 91 days after the last reply. New replies are no longer allowed.