Do I have these both set up correctly?

JavaScript
1 
onclick="document.getElementById('player').volume=1.0;player.play()"

onclick="document.getElementById('player').volume=1.0;player.paused ? player.play() :player.pause()"
2

Do you have them set up correctly? That’s a good question. What are you wanting to achieve, and do you have a sample page to help us test your situation?

3

I know the codes work, I just want to know if their written correctly.

4

What do you mean by correctly? Correctly according to the ECMAScript 5 specifications, correctly according to jslint.com, or correctly according to each of our own personal coding standards? Or some other kind of correctly?

1 Like
5

I asked about that in another post if there was a javascript checker.

6

Only you are likely to have seen all of your other threads. Can you please provide more detail for this thread?

7

It’s telling me this?

Expected ‘/’.

<button onclick="document.getElementById('player').volume=1.0;player.play()"></button>

<button onclick="document.getElementById('player').volume=1.0;player.paused ? player.play() :player.pause()"></button>
8

[quote=“asasass, post:7, topic:230014, full:true”]
It’s telling me this?[/quote]

What is telling you that?

9
10

jslint.com is only for JavaScript. It doesn’t do HTML.

That is only one of the many reasons why it’s better to keep your HTML, your CSS, and your JavaScript separate from each other.

11

Is there such think as an inline javascript checker?

12

Such as http://www.javascriptlint.com/online_lint.php ?

13

It’s telling me this is an error which makes no sense.
<
^
SyntaxError: syntax error

14

it’s trying to tell you that the HTML code needs to be contained within an HTML tag.

15

it is

<button onclick="document.getElementById('player').volume=1.0;player.play()"></button>

<button onclick="document.getElementById('player').volume=1.0;player.paused ? player.play() :player.pause()"></button>
16

This works: When I removed a question mark or a period, it told me error.
https://html5.validator.nu/

17

Yes indeed - and the linter is telling you that <button is not good to start with.

The validator only tells you that you have valid syntax. It doesn’t lint or tell you anything about preferred ways to code.

18

That’s exactly how it’s set up here:

19

That is an excerpt - it is not a full HTML page. All HTML should be contained within HTML tags. Do I need quote from the HTML specs for you to understand this, or are you willing to accept that some of us here can advise on this topic pretty well.

1 Like
21 
 <!DOCTYPE html>
<html>
<head>
<title>Title of the document</title>
</head>
<body>

<button onclick="document.getElementById('player').volume=1.0;player.play()"></button>
<button onclick="document.getElementById('player').volume=1.0;player.paused ? player.play() :player.pause()"></button>
</body>

</html>