Check if password has at least 1 capital letter

[multichild]

Ah, sorry, I was going all technical on myself then, when it was easier than I thought

[multichild]

Does this look ok to you, as it seems to be causing me problems.

else if (newpassword.length !> 5 && newpassword.length !< 51) {
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'You password needs to be between 6 and 50 characters long',
type: 'error',
confirmButtonText: 'Return'
} )

[SamA74]

You can add min and max values to the regex {6,50} if that’s easier.

[multichild]

is it like this cpradio, as tried it with normal brackets too and it doesnt seem to be reading the 2 length values

var is_correct_format = /^(?=.*\d){6,50}(?=.*[a-z])(?=.*[A-Z])(?!.*\s).*$/.test(newpassword);

[cpradio]

@multichild

else if (newpassword.length !> 5 && newpassword.length !< 51) {

No, that isn’t valid syntax.

@multichild

is it like this cpradio, as tried it with normal brackets too and it doesnt seem to be reading the 2 length values

var is_correct_format = /^(?=.*\d){6,50}(?=.*[a-z])(?=.*[A-Z])(?!.*\s).*$/.test(newpassword);

No, that is likely to be a failed attempt too. I actually think adding it to the regex will be a lot harder.

// if newpassword length is less than 6 or greater than 50
else if (newpassword.length < 6 || newpassword.length > 50) {
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'You password needs to be between 6 and 50 characters long',
type: 'error',
confirmButtonText: 'Return'
} )

[multichild]

Hi cpradio I have a little issue as I’m testing the change password option.

The first validation is to make sure they fill all the fields in, that works fine, then next then is that they use a capital and a number and this is where it doesnt seem to work corectly.

I type A1 as the new password and A1 to confirm password, and it doesnt validate, it still comes back as an error. I was hoping that A1 would validate but then it would go to the next validation to make sure its 6 or over and less than 50.

var oldpassword = $("input[name=\"old_password\"]").val();
var newpassword = $("input[name=\"new_password\"]").val();
var confirmpassword = $("input[name=\"confirm_password\"]").val();

var is_correct_format = /^(?=.*\d)(?=.*[a-z])(?=.*[A-Z])(?!.*\s).*$/.test(newpassword);

if (newpassword === '' || confirmpassword === '' || oldpassword === ''){
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'You need to fill in all the fields',
type: 'error',
confirmButtonText: 'Return'
})
} else if (!is_correct_format) {
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'You need to use at least 1 capital and 1 number.',
type: 'error',
confirmButtonText: 'Return'
})
} else if (newpassword.length < 6 || newpassword.length > 50) {
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'You password needs to be between 6 and 50 characters long',
type: 'error',
confirmButtonText: 'Return'
})
} else if (confirmpassword != newpassword){ 
document.getElementById('buttonSubmit').style.display = 'block';
swal({
title: 'Error!',
text: 'It seems like you have typed your confirm password incorrectly',
type: 'error',
confirmButtonText: 'Return'
} )
}

[multichild]

I got it, silly me testing with A1, as I need the undercase to not just the uppercase, sorry

[fretburner]

@Gandalf

I may sound like a broken record, but what if the visitor has JS switched off?

@multichild

I have discussed it with the team leader and its not their concern they said, so am carrying on until they realise it is a concern.

When it comes to input validation, my worry is not so much about users with JS disabled (although that’s a legitimate concern) but that it’s easily bypassed by malicious users who may try to break the system.

[SamA74]

@fretburner

but that it’s easily bypassed by malicious users who may try to break the system.

Agreed, there is nothing wrong with having client-side validation, it’s a good idea, but is for UX purposes only, not security.
It should always be backed up by robust server-side validation to be (more) secure.