Add comma between array?

[letsforum]

I have created an array but the result show as one long number! How to separate them with a comma?

> $query = $db->simple_select("tags", "tid");

> while($theme = $db->fetch_array($query))
> {
>     $tids = array();

>     $tids[] = $theme['tid'];

>     $hh = implode(', ', $tids);
>   echo $hh;
> }

P.S. When I use print_r it show like this:
Array
(
[0] => 4
)
Array
(
[0] => 7
)
Array
(
[0] => 5
)
Array
(
[0] => 6
)
Array
(
[0] => 8
)

[s_molinari]

@letsforum

$tids = array();

I’ll only ask a question, why is the above line in the loop, when it means you are resetting the variable back to an empty array with each iteration of the while loop? Oops, I said too much.

Scott

[letsforum]

@letsforum

$query = $db->simple_select(“tags”, “tid”);

I would like to fetch all tids from the TID column and then make them like this 1,2,3,4 etc. Then I will use this in the other query WHERE t.tid NOT IN

[terrydoang]

The implode should be outside of the while loop

[s_molinari]

It might be easier to just use a subquery in your WHERE statement too.

SQL Subquery

Scott

[letsforum]

How can I fetch all values without the looping it?

[Drummin]

Did you understand what Scott was saying in POST#2?

You define the array OUTSIDE the loop and then again implode would also be OUTSIDE the loop.

$query = $db->simple_select("tags", "tid");

$tids = array();
while($theme = $db->fetch_array($query))
{
    $tids[] = $theme['tid']; 
}    
$hh = implode(', ', $tids);
echo $hh;