mysql error msg

[safeasfcuk]

im getting this msg when im trying to display a list of items in my database any ideas why?

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/safeasfc/public_html/work/client/admin/index.php on line 220

 <p>Select the product range you want to edit<br>
 <input type=radio name=table value=clarice checked=checked> Clarice Cliff<br />
<input type=radio name=table value=welsh> Welsh Gaudy<br />
<input type=radio name=table value=deco> Deco Antique<br />
<input type=radio name=table value=royal> Royal Doulton<br />
<input type=Submit name="submit" value=Edit>
<?php

 if ($_POST['submit']) {

include ("dbconnect.php");

$sql="SELECT * FROM" . $_POST['table'];
$result=mysql_query($sql);
?>

<table width=293 border=1>
  <tr>
    <td width=171>Product Name</td>
    <td width=106>Update</td>
  </tr>
  <tr>
  <?php
  
while($rows=mysql_fetch_array($result)){    <-------------line 220
?>
	<td><?php echo $rows['name']; ?></td>
<td align="center"><a href="update.php?id=<? echo $rows['id']; ?>">update</a></td>
  </tr>
  <?php
  }
	?>
</table>
<?php
mysql_close();
}
}

[spikeZ]

It means your query failed to return any results probably because of an error.
Change your query line to:

$result=mysql_query($sql) or die(mysql_error()); 

and post back the resulting message if there is one.
Also sanitise your post data before using it in your query.

$sql="SELECT * FROM" . mysql_real_escape_string($_POST['table']); 

Spike

[safeasfcuk]

arr getting this error now m8 any ideas?

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROMdeco' at line 1

deco being the table name??

[egomac]

your query is returning false.

var_dump the $sql variable and paste the printed output in your phpmyadmin and see the explanation of the error.

[safeasfcuk]

what you mean var_dump sorry ??

im a little confussed because its thinking the table name is FROMdeco not just deco?

[foofoonet]

Online man is pretty clever: http://www.php.net/var_dump

[safeasfcuk]

ok now im more confussed why do i need to var dump?

[spikeZ]

lol, you don't need to var_dump!
you just need to add a space between the from and the variable!

$sql="SELECT * FROM " . mysql_real_escape_string($_POST['table']); 

should do you

Spike

[safeasfcuk]

il try that spike thank

[bitbytes]

try to print the query by echo on ur browser . for ex : select * from usermaster . after successfull output copy this query in mysql and try to run it. what will be the output ?

[safeasfcuk]

that worked a treat m8 thank lol so silly of me!