How Can I Turn This into One Function?

[JohnSaunders]

I have the following functions and I need to make them so they are just run under one function. Can somebody tell me how to do this? The only one that works is the check e-mail, then the other two do not work once I hit submit after typing in a valid e-mail address. If I remove the check e-mail function, it submits properly.

function validEmail(email) {
invalidChars = " /:,;"
// cannot be empty
if (email == "" ) {
return false
}
// does it contain any invalid characters?
for (i=0; i<invalidChars.length; i++) { 
badChar = invalidChars.charAt(i)
if (email.indexOf(badChar,0) > -1) {
return false
}
}
// there must be one "@" symbol
atPos = email.indexOf("@",1)
if (atPos == -1) {
return false
}
// and only one "@" symbol
if (email.indexOf("@",atPos+1) != -1) {
return false
}
// and at least one "." after the "@"
periodPos = email.indexOf(".",atPos)
if (periodPos == -1) {
return false
}
// must be at least 2 characters after the "."
if (periodPos+3 > email.length) {
return false
}
return true
}
// run the validEmail function
function checkAddress(inputStr) {
var mailValue = inputStr.value
if (!validEmail(mailValue)) {
alert("Please enter a valid email address" )
inputStr.focus()
inputStr.select()
return false
} else {
return true
}
}
 
function submit1()
{
document.ccoptin.action = "script.asp"
document.ccoptin.target = "_blank"
document.ccoptin.submit();
}
function submit2()
{
document.ccoptin.action = "script2.asp"
document.ccoptin.target = ""
document.ccoptin.submit();
}
 
<form name="ccoptin" method="post">
<input type="text" name="ea" value="Type e-mail here" size="15" onClick="this.value=''">
<a href="#" onClick="return checkAddress(ea);submit1();submit2()">
</form>

Also, does anybody know what the javascript code is instead of using href="#"? I believe it's something along the lines of href="javascript;".

[MikeFoster]

Hi John,

Your question is not the problem I see. I don't think you can issue two form submissions like that. I'm not sure... but I'm sure some of the other members know the answer.

[JohnSaunders]

Thanks for your response. I know it may not be "proper" but I'm positive it works cause that's what I've been using for a while. The problem is that people are just clicking submit and it is being processed without a valid e-mail address.

If you or anybody has any suggestions as to how I can do these three steps (the first one then if it's valid process the second and third ones), I woud appreciate it.

[MikeFoster]

Hi John,

The only changes I made are to the following. Am I getting close?

function checkAddress(inputStr) {
var mailValue = inputStr.value
if (!validEmail(mailValue)) {
alert("Please enter a valid email address" )
inputStr.focus()
inputStr.select()
} else {
submit1();
submit2();
}
}

<form name="ccoptin" method="post">
<input type="text" name="ea" value="Type e-mail here" size="15" onClick="this.value=''">
<a href="javascript: checkAddress(ea)">Submit</a>
</form>