DHTML Code Won't Work, PLEASE Help

**WebMasterAJ** · Sep 17, 2000 13:14

I just download a script from Dynamic Drive, the script being: http://www.dynamicdrive.com/dynamici...rollerlink.htm

I downloaded that, and followed the directions, and tried to install it on my site. Here is where the problem came into play.

I tried to install it here: http://www.finheaven.com/checkit.shtml (right under the main logo, by the arrows). But, as you can see, it just shows the arrows, no links, while it should show the links too. So, I went backwards, to try and solve the problem and thought I should put the script on a blank page here: http://www.finheaven.com/scrollerlink.htm

On a totally blank page, the script works. But when it is on a page with other information, it does not, why?

I would appreciate any help. Thanks.

**Kevin Yank** · Sep 17, 2000 13:29

It's because of the <div align="center"> surrounding your page contents. Change this to <div id="pagewrapper" align="center">, then adjust your script as follows:

Code:

function fillup(){
if (document.all){
pagewrapper.test2.innerHTML=menucontents
actualwidth=test2.offsetWidth
}
else if (document.layers){
ns_scroll=document.pagewrapper.document.ns_scrollmenu.document.ns_scrollmenu2
ns_scroll.document.write(menucontents)
ns_scroll.document.close()
actualwidth=ns_scroll.document.width
}
}
window.onload=fillup

[Edited by kyank on 09-17-2000 at 03:26 PM]

**WebMasterAJ** · Sep 17, 2000 13:43

I tried that, and it didn't work. Thanks anyhow... any one else have an idea?

**Kevin Yank** · Sep 17, 2000 13:55

What error message(s) are you getting? Double-click the small error icon in the lower-left of the MSIE window to find out.

**WebMasterAJ** · Sep 17, 2000 14:09

Actually, I don't get any error message. It just sits there and does the same thing it did before, nothing. I uploaded the site with the changes you recommended, just so you could see.

**Kevin Yank** · Sep 17, 2000 14:28

Hmm for some reason the document's onLoad event handler isn't firing. As a first step, I'd run your page through an HTML validator. In browsing your code, I've noticed several problems including a second set of <head> and <body> tags, unmatched quotes (e.g. <a href=#"> ), and others. An HTML validator would help correct all these problems, and hopefully serve to un-confuse Internet Explorer enough that it will correctly fire the onLoad event.

[Edited by kyank on 09-17-2000 at 03:31 PM]

**GeorgeC** · Sep 17, 2000 14:53

The problem is due to two scripts on your page both accessing the BODY onload event- the scroller link script, and Dynamic countdown script. In other words, there are two "window.onload" references on your page.

To save myself some typing, I'll simply refer you to the following tutorial to see how to resolve such a conflict: http://www.wsabstract.com/javatutors/multiplejava.shtml

**Kevin Yank** · Sep 17, 2000 14:57

Good spot, GeorgeC!

Just comment out the following two lines in your code by typing "//" at the start of them:

Code:

window.onload=fillup
window.onload=start_countdown

Then, in your <body> tag (once you've removed the second set of <head> and <body> tags), add:

Code:

<body ... onLoad="fillup();start_countdown();">

That should do it! Try it with and without the modifications I provided above to see which works.

**WebMasterAJ** · Sep 18, 2000 08:37

What would be a good HTML Validator?

**WebMasterAJ** · Sep 18, 2000 08:46

IT WORKS!

http://www.finheaven.com/checkit.shtml

Thank you guys so much for helping me out, I would of never of figured that one out.

Would you still be able to tell me a good HTML Validator? I use FrontPage, and many people say it messes with the code, so perhaps I should use it anyways.

Once again, thanks a lot!

**Kevin Yank** · Sep 18, 2000 08:46

http://validator.w3.org/

**WebMasterAJ** · Sep 18, 2000 09:00

Thanks again!

User Tag List

Thread: DHTML Code Won't Work, PLEASE Help

Thread Tools

Display

Bookmarks

Bookmarks

Posting Permissions