Mod Rewrite

**Banana Man** · Aug 30, 2012 09:19

This is driving me insane. I am trying to use mod rewrite to get from the url:

www.mysite.com/folder/?param=1

to:

www.mysite.com/folder/1

I have tried out about 10 different mod rewrite version from varios forums but nothing is working. I just keep on getting an Internal Server Error message. Below is one example i have tried but for the life on me can see the problem. Is this code correct? If it is any other ideas what might be causing the issue?

Thanks!

RewriteEngine On

RewriteBase /
RewriteRule ^/folder/(.*)$ /folder/index.php?param=$1 [NC]

**dklynn** · Aug 31, 2012 00:09

BM,

1. You don't need the RewriteBase.

2. You don't need (can't have) the leading / with an Apache 2.x server (it's required for an Apache 1.x server, though).

3. No Case is NOT appropriate for a RewriteRule (the {REQUEST_URI} variable IS case sensitive).

4. Make those mods then test with the flag(s) being [R=301,L] and remove the R=301, when you're satisfied it works.

Regards,

DK

**Banana Man** · Aug 31, 2012 03:48

Hi dklynn,

Thanks for the reply! I have tested what you recommended but im still getting the same error. I have tried the following all with the same result:

RewriteEngine On

RewriteRule ^/folder/(.*)$ /folder/index.php?param=$1 [R=301,L]

RewriteRule ^/folder/(.*)$ folder/index.php?param=$1 [R=301,L]

RewriteRule ^folder/(.*)$ folder/index.php?param=$1 [R=301,L]

I have other instructions in my .htaccess so maybe they are conflicting somehow?

# redirect non www. to www. domain

RewriteCond %{HTTP_HOST} ^mysite.com
RewriteRule (.*) http://www.mysite.com/$1 [R=301,L]

# Remove the file extension from URL's

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ $1.php [L,QSA]

# server automatically adds a PHP Session ID to URL's so this needs to be switched off

php_flag session.use_trans_sid off
php_flag session.use_only_cookies on

**dklynn** · Sep 1, 2012 15:53

BM,

(Not so) silly question first: Is mod_rewrite enabled? (Several ways to check and verify in my signature's tutorial.)

Your "other" mod_rewrite code is fine.

I've got to assume that you tried your new code (after the other mod_rewrite code) individually:

PLEASE wrap your code in [code]...[/code] tags as that preserves the code when quoting for a reply.

Code:

RewriteEngine On

RewriteRule ^/folder/(.*)$ /folder/index.php?param=$1 [R=301,L]
# This will ONLY work on an Apache 1.x server (^/) and
# ^ will only work on an Apache 2.x server.
# If you're not sure what you're using, use ^/? as that works with both.

# the / in the redirection is first interpreted as "server root" but should be okay.

# (.*) is a terrible thing to use: 

[standard rant #1]The use of "lazy regex," specifically the :kaioken: EVERYTHING :kaioken: atom, (.*), and its close relatives, is the NUMBER ONE coding error of newbies BECAUSE it is "greedy." Unless you provide an "exit" from your redirection, you will ALWAYS end up in a loop![/standard rant #1]

# In other words, use the !-f test to prevent looping on folder/index.php!

RewriteRule ^/folder/(.*)$ folder/index.php?param=$1 [R=301,L]
# same ^/ problems (#1 and #3) as above

RewriteRule ^folder/(.*)$ folder/index.php?param=$1 [R=301,L]
# Same loopy problem (#3 above).

Code:

# redirect non www. to www. domain

RewriteCond %{HTTP_HOST} ^mysite.com
RewriteRule (.*) http://www.mysite.com/$1 [R=301,L]
# I prefer to use existing variables rather than create new ones so I use
# RewriteRule .? http://www.mysite.com%{REQUEST_URI} [R=301,L]
# but your RewriteRule is the more common use (by noobies)

# Remove the file extension from URL's

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ $1.php [L,QSA]
# I will check whether $1.php exists as a file before making this redirection

# server automatically adds a PHP Session ID to URL's so this needs to be switched off

php_flag session.use_trans_sid off
php_flag session.use_only_cookies on

Technique tip: Because Apache's core directives are executed before mod_rewrite, I will always list them first.

Regards,

DK

**Banana Man** · Sep 4, 2012 09:46

Hi dklynn,

I dont understand what you mean when you say to use the !-f test to prevent looping on folder/index.php?

From your notes above i gather that the below should work then on apache 1 and 2 server, but i should change the (.*)?

[code]RewriteRule ^/folder/(.*)$ /folder/index.php?param=$1 [R=301,L][\code]

I have tried about 6 different .htaccess code generators all with no luck. There is clearly something fundamental i am doing wrong here but i still cant figure out what?

**dklynn** · Sep 4, 2012 15:50

BM,

If mod_rewrite enabled? Have you confirmed that (and that it works on a simple test)? EVERYTHING else would be a waste of time if it's not enabled for you.

Originally Posted by Banana Man

I dont understand what you mean when you say to use the !-f test to prevent looping on folder/index.php?

That's simply one way to escape from the loop you're generating with the inappropriate use of (.*), i.e., test whether the file exists before redirecting back to it with your LOOPY code.

[standard rant #1]

The use of "lazy regex," specifically the

EVERYTHING

atom, (.*), and its close relatives, is the NUMBER ONE coding error of newbies BECAUSE it is "greedy." Unless you provide an "exit" from your redirection, you will ALWAYS end up in a loop!

[/standard rant #1]

From your notes above i gather that the below should work then on apache 1 and 2 server, but i should change the (.*)?

WRONG! In the RewriteRule, the slash is required (in the DocumentRoot) by Apache 1.x servers following the start anchor, i.e., ^/... Apache 2.x assumes that there is a / following the domain name so it will NOT match ^/, it will only match ^. If you don't know which version of Apache you're using (then shame on you), you can use ^/? as that's accepted by both versions of Apache.

[code]RewriteRule ^/folder/(.*)$ /folder/index.php?param=$1 [R=301,L][\code]

As explained above, there are two problems with this (if using Apache 2.x): The leading / and the simple fact that (.*) will match the redirection (index.php) and loop. Since you're not locking up the server with your loop, you can assume that you're using an Apache 2.x server (it'll make 10 attempts before giving up but it won't lock-up the server and require a restart).

I have tried about 6 different .htaccess code generators all with no luck. There is clearly something fundamental i am doing wrong here but i still cant figure out what?

Forgive me for stating the obvious: If you don't know what you're doing, it's likely that you're not inputting good information to the code generators (which MUST make some assumptions - I know! I created a mod_rewrite generator and it's not a trivial exercise). It would be far simpler for you to spend a few minutes with a tutorial (like the one linked below) which lays it all out for you and has helped many members learn about mod_rewrite over the several years it's been online.

Regards,

DK

**Banana Man** · Sep 5, 2012 04:50

I checked my phpinfo() file but mod_rewrite wasn't listed. I have been in contact with my hosting company and they assure me that even though it is not listed in my phpinfo() it is turned on on my server.

**dklynn** · Sep 6, 2012 01:05

BM,

Did you run the test with the code I provided in the tutorial? That will give you a definitive answer.

Regards,

DK

**Banana Man** · Sep 6, 2012 01:54

I tested it and it is working ok. I see the "this is a PHP file" text.

I was wondering is it ok to have the .htaccess file save at my root folder or should it be in the /folder/ as that is what i am trying to effect? I have tried both but not with every test i have tried.

**dklynn** · Sep 6, 2012 14:51

BM,

Well, that's as good a confirmation as you can get!

As a rule, I keep my .htaccess in the DocumentRoot so I can see all the interactions (conflicts) at a single glance. You CAN do either but that will complicate things unnecessarily for you.

Regards,

DK

**Banana Man** · Sep 9, 2012 09:43

So i finally got it working. I am using the following:

Code:

Options +FollowSymLinks
RewriteEngine on
RewriteRule (.*)/(.*)/$ /folder/index.php?param1=$1&param2=$2

which converts:

Code:

www.mysite.com/folder/index.php?param1=test&param2=1

to:

Code:

www.mysite.com/test/1/

The problem was that i had this code beforehand which must have been causing some kind of conflict:

Code:

# Remove the file extension from URL's

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ $1.php [L,QSA]

**ScallioXTX** · Sep 9, 2012 12:06

Off Topic:

When posting .htaccess files, order matters! So if you have a block A and a block B in your .htaccess file it is wise to also post in which order they are in your .htaccess file.
In this particular post that would have made the problem clear after post #3 (where the OP posts two blocks but it turns out the second one actually came before the first one he posted)

This is not to attack anyone, just to telling the OP and others a way we can better help them

**Banana Man** · Sep 11, 2012 01:53

Another day another .htaccess problem

I now have a new problem with this code. If i try to navigate to www.mysite.com/folder2/ i.e. droping the index.php at the end i get a server error. It works if i use the full address i.e. www.mysite.com/folder2/index.php. It seems to be trying to use the new mod rewrite rule i just added even though a different folder has been specified. Any ideas why this is happening?

Code:

Options +FollowSymLinks
RewriteEngine on

# redirect non www. to www. domain

RewriteCond %{HTTP_HOST} ^mysite.com
RewriteRule (.*) http://www.mysite.com/$1 [R=301,L]


# server automatically adds a PHP Session ID to URL's so this needs to be switched off

php_flag session.use_trans_sid off
php_flag session.use_only_cookies on


# remove the variables when passed through domain URL

RewriteRule (.*)-(.*)/$ /folder1/index.php?param1=$1&param2=$2


# Remove the file extension from URL's

RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)$ $1.php [L,QSA]

Thanks!

**dklynn** · Sep 11, 2012 15:32

BM,

[rant #1 REPEATED]

The use of "lazy regex," specifically the

EVERYTHING

atom, (.*), and its close relatives, is the NUMBER ONE coding error of newbies BECAUSE it is "greedy." Unless you provide an "exit" from your redirection, you will ALWAYS end up in a loop!

[/rant #1]

Sorry, you are NOT specifying a folder with (.*) but matching EVERYTHING (or NOTHING). That's been the problem and it's still the problem.

Once you finally get into your folder2 directory, DirectoryIndex index.php will specify that index.php will be served if only the directory is requested.

Regards,

DK