Need help in object oriented programming

**paul_wilkins** · Dec 23, 2011 03:25

Originally Posted by shippuuden

Cool, I didn't know that.

But those two alerts are still not working.

You'll need to update me with the code you are now using.

**shippuuden** · Dec 23, 2011 03:33

I have made few additional changes as well. It has fixed part of the problem.

Total changes made:

Code:

function Custom_rounded_container(selector, color)
{
	/*
	if(selector == undefined)
	{
		alert("selector is undefined");
	}
	else
	{
		alert("selector is:		" + " " + selector);
		alert("Inside Custom_rounded_container");
	}
	*/
	alert("Inside Custom_rounded_container");

	this.temp_array = selector && selector.split(" ");
	//alert(this.temp_array);
	this.color = color;
}

Removed this code:

Code:

All_rounded_corners_one_element.prototype.superclass = Custom_rounded_container;

Made change in All_rounded_corners_one_element function:

Code:

function All_rounded_corners_one_element(selector, color)
{
	alert("Inside All_rounded_corners");
	Custom_rounded_container.call(this);
	//this.superclass(selector, color);
}

Now

Code:

function Factory_rounded_corners(selector, color, type, numb_elem)
{
	var rounded_container;
	if(numb_elem == "one" && type == "all_round")
	{
		rounded_container = new All_rounded_corners_one_element(selector, color);
		alert(rounded_container.color);//Still Not working
		alert(rounded_container.temp_array); // Still Not working
		rounded_container.elements_to_be_affected();//Working
		
	}
}

**shippuuden** · Dec 23, 2011 03:39

It has fixed what originally was not working but now what was originally working is now not working..lol

**paul_wilkins** · Dec 23, 2011 03:41

Originally Posted by shippuuden

It has fixed what originally was not working but now what was originally working is now not working..lol

Step by step, that's the way to do it. Give me a few moments to catch up. I've given up any hope of that jsfiddle being updated, and am attempting to match what you're doing (badly) with local code instead.

**shippuuden** · Dec 23, 2011 03:44

Opps sorry I'l update jsfiddle.

First time I'm using it so forgot to update it.

**shippuuden** · Dec 23, 2011 03:46

http://jsfiddle.net/shippuuden/pzrgL/1/

**paul_wilkins** · Dec 23, 2011 03:49

Originally Posted by shippuuden

http://jsfiddle.net/shippuuden/pzrgL/1/

Currently you have mootools loaded, with the javascript activating in the web pages onload event.

You should use no library instead of mootools, change the loading to no wrap (in body).
After that the HTML code should have the scripting code at its end removed, and placed at the end of the scripting section instead.

**shippuuden** · Dec 23, 2011 04:01

I don't think I'm using it correctly. I have done as you said.

After reading the jsfiddle documentation under Fiddle Settings (Sidebar) section:

it says 'no wrap(body):
do not wrap the JavaScript code, place it in <body> section'

I have now added body tags in html section and moved the javascript code from below the html section to just below the body section.

Is that what you meant?

The updated javascript if it makes it easier:

Code:

/* Function	Factory_rounded_corners
*	-------------------------
*	Parameter: selector
*	Return: None
*	Description: Create a rounded container around elements to be affected
*/
function Factory_rounded_corners(selector, color, type, numb_elem)
{
	var rounded_container;
	if(numb_elem == "one" && type == "all_round")
	{
		rounded_container = new All_rounded_corners_one_element(selector, color);
		alert(rounded_container.color);//works
		alert(rounded_container.temp_array); // works
		rounded_container.elements_to_be_affected();//Does not work
		
	}
}
/* Function	All_rounded_corners
*	-------------------------
*	Parameter: selector
*	Return: None
*	Description: Create a rounded container around elements to be affected
*/
function All_rounded_corners_one_element(selector, color)
{
	alert("Inside All_rounded_corners");
	Custom_rounded_container.call(this);
	//this.superclass(selector, color);
}


/*	Function custom_rounded_container
*	----------------------------------
*	Parameters: selector
*	Properties: this.temp_array
*	Methods: this.elements_to_be_affected, this.apply
*	Returns: Returns a object 
*	Description: selector parameter should be in two formats: id of element if only one element is to be affected ie: 'content'
				or id of surrounding element and the tag of the elements to be affected, ie: 'content li' 
*/
function Custom_rounded_container(selector, color)
{
	/*
	if(selector == undefined)
	{
		alert("selector is undefined");
	}
	else
	{
		alert("selector is:		" + " " + selector);
		alert("Inside Custom_rounded_container");
	}
	*/
	alert("Inside Custom_rounded_container");

	this.temp_array = selector && selector.split(" ");
	//alert(this.temp_array);
	this.color = color;
}
Custom_rounded_container.prototype.test = function()
{
	alert("Inside test");
}
/*	Function elements_to_be_affected
*	----------------------------------
*	Parameters: None
*	Properties: None
*	Local variables:	None 
*	Local methods: None
*	Returns: elements in array or one element
*	Description: Custom_rounded_container that retrieves elements to be affected
*/
Custom_rounded_container.prototype.elements_to_be_affected = function()
{
	alert("Inside elements_to_be_affected");
	//alert(this.temp_array.length);

		//return  = document.getElementById(this.temp_array[0]).getElementsByTagName(this.temp_array[1]);
		/*
		children_elements = function(parent_element)
		{
			switch(parent_element.nodeName)
			{
				case 'UL': return parent_element.getElementsByTagName("li");
			}
		}
		*/
		//return children_elements(parent_element[0]);
}

//All_rounded_corners_one_element.prototype.superclass = Custom_rounded_container;
//alert(rounded_container.selector);//works
//alert(rounded_container.color);
//All_rounded_corners_one_element.prototype  = new Custom_rounded_container(selector, color);
All_rounded_corners_one_element.prototype  = new Custom_rounded_container();
All_rounded_corners_one_element.prototype.constructor = All_rounded_corners_one_element;

**paul_wilkins** · Dec 23, 2011 04:04

Originally Posted by shippuuden

I don't think I'm using it correctly. I have done as you said.

No, remove ALL of the scripting code from the HTML section. It doesn't belong there and more importantly, tries to execute before any of the other scripting code has even begun yet to exist.

**shippuuden** · Dec 23, 2011 04:05

http://jsfiddle.net/shippuuden/pzrgL/3/

**shippuuden** · Dec 23, 2011 04:07

http://jsfiddle.net/shippuuden/pzrgL/6/

javascript code at end of the javascript section now.

**paul_wilkins** · Dec 23, 2011 04:08

Originally Posted by shippuuden

http://jsfiddle.net/shippuuden/pzrgL/6/

javascript code at end of the javascript section now.

Don't forget to remove it from the HTML section.

**shippuuden** · Dec 23, 2011 04:10

Opps sorry, all done now.

http://jsfiddle.net/shippuuden/pzrgL/8/

**paul_wilkins** · Dec 23, 2011 04:11

Originally Posted by shippuuden

Opps sorry, all done now.

http://jsfiddle.net/shippuuden/pzrgL/8/

These lines do work now.

Code:

alert(rounded_container.color);//Does not work
alert(rounded_container.temp_array); // Does not work

It is expected behaviour for them to have undefined values when the Constructor is called with undefined values.

**shippuuden** · Dec 23, 2011 04:19

Its working now.

I forgot to add

selector and color when calling the parent constructor.

Code:

Custom_rounded_container.call(this, selector, color);

Its working now

Thanks for your help Paul.

Greatly appreciated.

**paul_wilkins** · Dec 23, 2011 04:19

This is where it is called with no further arguments.

Code:

Custom_rounded_container.call(this);

Is it possible that you meant to use this instead?

Code:

Custom_rounded_container.call(this, selector, color);

**shippuuden** · Dec 23, 2011 04:20

http://jsfiddle.net/shippuuden/pzrgL/11/

All working now.

**paul_wilkins** · Dec 23, 2011 04:20

Originally Posted by shippuuden

http://jsfiddle.net/shippuuden/pzrgL/11/

All working now.

Hurrah, that's what we like to see

**shippuuden** · Dec 23, 2011 04:24

Yep, thats what I changed it to.

and I figured out why it wasn't working with the superclass bit of code

Code:

All_rounded_corners_one_element.prototype.superclass = Custom_rounded_container;

needed to be after

Code:

All_rounded_corners_one_element.prototype  = new Custom_rounded_container();
All_rounded_corners_one_element.prototype.constructor = All_rounded_corners_one_element;

like so:

Code:

All_rounded_corners_one_element.prototype  = new Custom_rounded_container();
All_rounded_corners_one_element.prototype.constructor = All_rounded_corners_one_element;
All_rounded_corners_one_element.prototype.superclass = Custom_rounded_container;

instead of

Code:

All_rounded_corners_one_element.prototype.superclass = Custom_rounded_container;
All_rounded_corners_one_element.prototype  = new Custom_rounded_container();
All_rounded_corners_one_element.prototype.constructor = All_rounded_corners_one_element;

**shippuuden** · Dec 23, 2011 04:25

Thanks once again.

Now I can start creating parent methods and implementing them.

User Tag List

Thread: Need help in object oriented programming

Thread Tools

Display

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions