SitePoint Sponsor

User Tag List

Results 1 to 3 of 3
  1. #1
    SitePoint Zealot
    Join Date
    Jul 2009
    Posts
    113
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)

    HTML5 code review

    Hi,

    I have built a simple page with html5, following tutorials on the internet and a book that I have but I'm not sure if the elements, logic and strucure that I have used are corrected especially as I have still had to use divs.

    Could somebody please check the code to see if they see any faults or if I should be using different elements in certain places? I 've validated in W3C and it's all good:


    Aprendems microsite en HTML5

    I know it's a very simple page but would appreciate the help.

    Thanks!

  2. #2
    Utopia, Inc. silver trophy
    ScallioXTX's Avatar
    Join Date
    Aug 2008
    Location
    The Netherlands
    Posts
    8,907
    Mentioned
    139 Post(s)
    Tagged
    2 Thread(s)
    You're using all the elements in all the wrong places ...

    <header> is to be used for the header of the website; your website doesn't really have one, but for example on this forum it would be the top of the top of the page with the logo, slogan, search field, etc. As such it would be highly unlikely to several <header> elements, and it's certainly not meant to use around every <hn> tag. Maybe you're confusing it which <hgroup> (which is already removed from html5 -- or "html", or whatever it's called today) spec AFAIK).

    Then there is only one section in your page, which is also incorrect; the <div class="advantages"> and <div class="features"> are both <sections>s, not <divs>.
    Rémon - Hosting Advisor

    Minimal Bookmarks Tree
    My Google Chrome extension: browsing bookmarks made easy

  3. #3
    SitePoint Zealot
    Join Date
    Jul 2009
    Posts
    113
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    thanks for the help, so if I change those divs (advantages & features) to sections, do I also have to put the content into article tags too? Is it right that these two sections should be in a global section like I have done?

    Also instead of <header> what should I use for the tagline "Encuentra el Curso de Educadora Infantil...

    thanks!


Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •