php value passing

[nofel]

hi,
i am having trouble echoing from posted page, in the url it shows the send id but it gives me error for this query

$_GET['$songs_set["id"]'];

and i get this error
Undefined index: $songs_set["id"]

[guido2004]

What does the url look like?
My guess is it should be:

$_GET['id'];

[StarLion]

I'm guessing actually you've gotten your arrays backwards.

Were you trying to do $songs_set[$_GET['id']] ?

[nofel]

What does the url look like?
My guess is it should be:

$_GET['id'];

single.php?song =1

[nofel]

Were you trying to do $songs_set[$_GET['id']] ?

yes

[guido2004]

single.php?song =1

I hope there is no space between song and =

[nofel]

single.php?song =1

I hope there is no space between song and =

there is and i was wondering if that is the reason
edit : i fixed the gap

[guido2004]

The undefined index error is because you had things mixed up like StarLion said.
Change your code like he told you, and try again.

[nofel]

The undefined index error is because you had things mixed up like StarLion said.
Change your code like he told you, and try again.

i still get the error

$_REQUEST['id'];
$song = $_REQUEST["id"];

Notice: Undefined index: id

Notice: Undefined index: $songs_set["id"]

[guido2004]

Because the variable name isn't 'id', but 'song'. You called it that way in the query string.

single.php?key=value

$_GET['key'] contains value

single.php?song=1 (get rid of that space)

$_GET['song'] contains 1

[nofel]

Because the variable name isn't 'id', but 'song'. You called it that way in the query string.

single.php?key=value

$_GET['key'] contains value

single.php?song=1 (get rid of that space)

$_GET['song'] contains 1

i didn't got any of it.

[guido2004]

Let's add some color:

single.php?key=value

$_GET['key'] contains value

single.php?song=1 

$_GET['song'] contains 1

I can't explain it any clearer than that.
Do a print_r($_GET); in your code to see the contents of $_GET.

[nofel]

i don't know what is wrong. i am reading a tut too it says the same about passing and getting value, this is page 1

<a href=\"single.php?song=key{$songs_set["id"]}\">".$songs_set["title"]."</a>

this is page 2

$song = $_REQUEST['id'];

and i m echoing on page 2

echo $song;

[nofel]

here is my code

<form action="single.php" method="post">
                                <div class="songslist">
                                    <table class="songs" width="1020" border="0" cellpadding="0" cellspacing="0">
                                    <tr>
                                        <th width="281">Artist</th>
                                        <th width="281">Title</th>
                                        <th width="204">Length</th>
                                        <th width="204">Genre</th>
                                        <th width="50">Ratings</th>
                                    </tr>
                                    </table>
                                    <table class="songs" width="1020" border="0" cellpadding="0" cellspacing="0">
                                    <tr>
                                    <?php
                                    $songs = mysql_query("SELECT * FROM songs LIMIT 10");
                                    if($songs){
                                        echo mysql_error();
                                    }
                                    while($songs_set = mysql_fetch_array($songs)){
                                        echo "<tr>
                                               <td width=\"281\">".$songs_set["artist"]."</td>"
                                            . "<td width=\"281\"><a href=\"single.php?song={$songs_set["id"]}\">".$songs_set["title"]."</a></td>"
                                            . "<td width=\"204\">".$songs_set["length"]."</td>"
                                            . "<td width=\"204\">".$songs_set["genre"]."</td>"
                                            . "<td width=\"50\">".$songs_set["rating"]."</td><tr>";
                                    }
                                    ?>
                                    </table>
                     </div>
                         </form>

and here is the single page

<?php
$song = $_REQUEST['id'];
echo "$song";
?>

now can u guide me where am i going wrong?

[guido2004]

single.php?song=1

$_REQUEST['id'];

This is where you're going wrong.
Like I told you, do a print_r($_GET); in your code (or a print_r($_REQUEST); ), and you'll see what exactly is sent to single.php

[nofel]

its a empty Array. i still don't understand what i m going wrong

[guido2004]

Change

song={$songs_set["id"]} 

in

song={$songs_set['id']} 

That line should have given you an error though.

[nofel]

u told me to remove double quotes. but it didn't solve the undefined index error on next page

[guido2004]

Did you change id to song?

[nofel]

[QUOTE=guido2004;4881072]Did you change id to song?[/QUOTE} still undefined index error

[guido2004]

and the print_r of $_GET still gives an empty error?

Can you check the html code of the first page in your browser and post the link code here?

[nofel]

well i get undefined index for print_r for songs.i did posted the page code above,here i'll do it again

<form action="single.php" method="post">
                                <div class="songslist">
                                    <table class="songs" width="1020" border="0" cellpadding="0" cellspacing="0">
                                    <tr>
                                        <th width="281">Artist</th>
                                        <th width="281">Title</th>
                                        <th width="204">Length</th>
                                        <th width="204">Genre</th>
                                        <th width="50">Ratings</th>
                                    </tr>
                                    </table>
                                    <table class="songs" width="1020" border="0" cellpadding="0" cellspacing="0">
                                    <tr>
                                    <?php
                                    $songs = mysql_query("SELECT * FROM songs LIMIT 10");
                                    if($songs){
                                        echo mysql_error();
                                    }
                                    while($songs_set = mysql_fetch_array($songs)){
                                        echo "<tr>
                                               <td width=\"281\">".$songs_set["artist"]."</td>"
                                            . "<td width=\"281\"><a href=\"single.php?song={$songs_set['id']}\">".$songs_set["title"]."</a></td>"
                                            . "<td width=\"204\">".$songs_set["length"]."</td>"
                                            . "<td width=\"204\">".$songs_set["genre"]."</td>"
                                            . "<td width=\"50\">".$songs_set["rating"]."</td><tr>";
                                    }
                                    ?>
                                    </table>
                     </div>
                         </form>

and second page

print_r ($_POST['song']);

[guido2004]

Why don't you just do what I ask you?
The first time I asked you about $_GET, you changed things to $_REQUEST.
Now, you change things to $_POST.

Of course things don't work. You send the data in the query string of the link, so $_POST is empty. You must use $_GET.

[nofel]

Why don't you just do what I ask you?
The first time I asked you about $_GET, you changed things to $_REQUEST.
Now, you change things to $_POST.

Of course things don't work. You send the data in the query string of the link, so $_POST is empty. You must use $_GET.

my bad.. i m just lost. it worked so now can i use this id to put it in query to get information from the table?
p.s - thanks

[guido2004]

my bad.. i m just lost.

Yes, I understand the feeling And it's a good thing you're not just waiting for answers, but also trying yourself. It's just hard to help when the feedback says my suggestions didn't work, while in reality they did work, but other changes created a new error (or even worse, the same error).

it worked

good

so now can i use this id to put it in query to get information from the table?

First you'll have to sanitize it. If it's supposed to be a number, cast it with (int). If it's a string, put it through mysql_real_escape_string. And then you can use it in a query.