POLL: How do you format your php?

[EastCoast]

I'm with Zalucius and ScallioXTX (style known as ANSI or Allman)

Style B is known as Whitesmiths.

[Stormrider]

A is known as K&R or 1TBS - the One True Brace Style.

Allman has the opening braces on a new line, but not indented.

[paul_wilkins]

A is known as K&R or 1TBS - the One True Brace Style.

Not quite. K&R and 1TBS are where classes and functions have braces on a new line, while control statements keep it on the same line.

function func()
{
    if (condition) {
        ...
    }
}

K&R allows optional braces on control statements.

if (condition)
    func();

1TBS makes braces mandatory.

if (condition) {
    func();
}

[Stormrider]

Yeh, which is what a lot of people seem to do. I use 1TBS but with functions and classes following the same rules as everything else.

[Karl]

I use a different line for class and functions, but the same line on if, else, foreach parts.

function someFunc()
{
    if (condition) {
        ...
    }
}

Same here, function, class or switch I put it on a new line, everything else gets it inline.

[dnordstrom]

class Demo {
  function __construct() {
    echo 'Opening brace on same line.';
  }
}

In PHP I type opening brace on the same line, after a space. That's what I learned when I read my first C++ book and it has stuck with me since then. Neat indenting makes this very clean and easy to read in my opinion. I'm currently reading the book "Clean Code: A Handbook of Agile Software Craftsmanship" which I really recommend for both intermediate and advanced coders fine-tuning their habit of writing clean code.

Recently I've been using Ruby though so I haven't had to care much about braces at all.

But let's not forget what's most important of all for writing clean code; consistency. You, and your team, should settle for a coding style and go with it during the entire project. I've seen projects where different programmers use different styles and it isn't pretty.

[w3dx]

I favour style "A", or rather a variation of 1TBS as mentioned earlier. Like @stormrider, I style classes and functions the same as other control structures.

However, with "A" the 2nd to last closing brace should be indented...

function name() { 
   function last() { 
      // Do something 
   } 
} 

The closing brace always matches a control statement... function, if, while, etc.

I used to code in Delphi as well, although I have never mimicked the positioning of BEGIN...END with the opening/closing braces {...} as in Allmans style - I think because the opening brace on its own always looked like a waste of space to me and by including the opening brace on the same line you could see more code without having to scroll.

I actually find style "B" where you have indented the braces as well (Whitesmiths style) a bit confusing. If I was to give the opening brace its own line I wouldn't indent it, keeping it inline with the control structure (which is more like true 1TBS) ...

function name() 
{ 
   function last() 
   { 
      //Do something 
   } 
} 

[benj80]

opening brace on a new line PLEASE people!!

[paul_wilkins]

opening brace on a new line PLEASE people!!

Is that a personal preference, or a style guide of some particular name that you require to be followed?

[Jay.P]

Is that a personal preference, or a style guide of some particular name that you require to be followed?

Can't you see the urgency? This is how it simply must be done! PLEASE PAUL!

[tangoforce]

I don't mind the opening brace on the same line as long as the closing brace is indented so you can see what it is closing. The number of bits I code I see with this is a disgrace:

function name(){
   //do something
   function else(){
      //do something
}
} 

Imagine having a rather large file to debug and all the closing braces are like that. Nasty stuff that is.

[rageh]

I always use option A. But if it is one line conditional code. I put everything in one line with the braces on.
Ex,

if(userFound($username)){doThis();}

For me option B is out of the question. I don't like it at all.