onclick event. Do I need quotes here...

[Mike]

Hey, this is the code (kinda) from one of my forms:

<form name="submit1">
...
<input type="text" name="text">
<input type="button" name="verify" value="Verify" onClick="window.open('test.' + document.submit1.text.value ,'location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no' )" style="font-size: 8pt; font-family: Verdana; height: 21; width: 53">
...
</form>

I cant get it to work because + document.submit1.text.value is just sitting there withought quotes. What can i do to fix that? Thanks,

[jonsteele]

If I am guessing right, you are trying to open the value of the text box, in that case

onClick="window.open('test', document.submit1.text.value ,'location=no,menubar...

[Mike]

actually, I'll be opening a php page with the value of the selected textbox item as a variable.

I was just playing tith the script so that i would open an html page named test.htm (htm would be the value)

<input type="button" name="verify" value="Verify" onClick="window.open('verifycat.php?cat=' + document.submit1.comp_category.value)" style="font-size: 8pt; font-family: Verdana; height: 21; width: 53">

[Mike]

I just need to know how to fit the other options into it (scrollbars, resizable...)

[Mike]

anyone?

[jonsteele]

This should work:


onclick="window.open('','verifycat.php?cat=' + document.submit1.comp_category.value+'','scrollbars=no,etc.')"

[Mike]

Originally posted by jonsteele
This should work:


onclick="window.open('','verifycat.php?cat=' + document.submit1.comp_category.value+'','scrollbars=no,etc.')"

What do the two '' do?

[Mike]

Just tried it, no luck

[mattjacob]

You'll need to concatenate the two strings into a new variable before using them in the function.

[Mike]

OK, thanks matt I'll go get a dictionary so I know what that means

[Mike]

OK, I got it working. I'd just like to send a big shout-out and thanks to Wavelan for sending me the code

[jonsteele]

care to share

[Mike]

<script type="text/javascript">
<!--
function openwin(){

var cat = "mypage.php?cat=";
var cat2 = document.formname.formfield.value;
var cat3 = cat + cat2;

window.open('cat3','category','scrollbar=0,location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no');
document.close();

}
//-->
</script>


<input type="button" name="verify" value="Verify" onclick="openwin()">

[Andrew-J2000]

Originally posted by naramation

<script type="text/javascript">
<!--
function openwin(){

var cat = "mypage.php?cat=";
var cat2 = document.formname.formfield.value;
var cat3 = cat + cat2;

window.open('cat3','category','scrollbar=0,location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no');
document.close();

}
//-->
</script>


<input type="button" name="verify" value="Verify" onclick="openwin()">

shouldn't cat3 be without quotes

[Mike]

I think so, but I don't know much js, thats why i posted here

It does work with quotes though. I'll try without.

[Andrew-J2000]

if you have it in quotes, the url will be cat3, but without them it will show the url any way i'd do it a bit differently anyway.

var cat = "mypage.php?cat=";
var cat2 = document.formname.formfield.value;
var cat3 = cat + cat2;

<script type="text/javascript">
<!--
function openwin()
{
  window.open('mypage.php?cat=' + document.formname.formfield.value,'category','scrollbar=0,location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no');
  document.close();
}
//-->
</script> 

[Mike]

I tried that in the onclick right in the button, but it didn't work

window.open('mypage.php?cat=' + document.formname.formfield.value,'category','scrollbar=0,location=no,menubar=no,resizable=no,scrollbars=no,status=no,toolbar=no');


Is there a problem with wavelan's code, other than the quotes?