Originally Posted by
eLePHANT
If there's anything you'd like to recommend about my site, please feel free to say so. I'm currently in the process of revamping my website. If you were a potential client, is there anything you are looking for that isn't there? I'm going to try and rework the header. I wish there was a really tutorial on creating a really effective website header, but I can't find it even afte searching google and youtube.
Hi,
I'm afraid that design isn't my strong-point (as you can tell by my site) and I'm more interested in the code underneath. The html code on your site looks fine and well structured so I can't really suggest anything else there.
Perhaps the design could do with a bit of flexibility and use min and max width instead of a fixed width (ie6 would need the fixed width though as it doesn't understand min/max). Having an elastic width could let your content grow and shrink with the viewport a bit more. I;d keep the sidebar a fixed width but let the content fill the available space.
I notice in your code you have this:
Code:
#wrapper {
width: 850px;
min-width: 600px;
margin: 30px auto;
}
If you set a width then you get width so the min-width is redundant if it is the same unit as it will never come into play. If the min-width was larger than the width you set then you would get a fixed width still but at the larger size. Just remove the min-width as it is redundant.
If you had said:
Code:
#wrapper {
width: 80%;
min-width: 600px;
margin: 30px auto;
}
Then that would be valid because the width is fluid and at some point the min-width would be triggered (assuming it wasn't viewed on a small mobile of course).
For a review or suggestions on your site design then visit the review sections of the forums where you can get comments on the design (you have to review 3 other sites first before you are eligible to place your site for review).
Bookmarks