Syntax for <script> within PHP (for validation)

[bonsai99]

Hope someone can help with this.

I've basically been checking my validation for a site, and have a page with a single error :

<SCRIPT>
✉
The attribute given above is required for an element that you've used, but you have omitted it. For instance, in most HTML and XHTML document types the "type" attribute is required on the "script" element and the "alt" attribute is required for the "img" element.

Typical values for type are type="text/css" for <style> and type="text/javascript" for <script>.

I think I've figured out its due to the PHP code that starts :

<?php
if ($row_rsModels)     {
  echo "<SC" . "RIPT>\n";
  echo "var WAJA = new Array();\n";

  $oldmainid = 0;
  $newmainid = $row_rsModels["Make"];
  if ($oldmainid == $newmainid)    {
    $oldmainid = "";
  }

ie the echo "<SC" . "RIPT>\n"; line

How would I incorporate the type="text/css" part in there for it to validate?

I've tried a few things, but presumably just have the syntax wrong.

If anyone could point me in the right direction, that would be much appreciated.

Thanks.

[guido2004]

Who knows why that line has been cut in two
Anyhow, try this

echo "<SCRIPT type=\"text/javascript\">\n";

[Shrapnel_N5]

Better not to mess with PHP syntax at all. Just escape it

<?php
if ($row_rsModels)     {
?>
<SCRIPT type="text/javascript">
  var WAJA = new Array();
<?
  $oldmainid = 0;
  $newmainid = $row_rsModels["Make"];
  if ($oldmainid == $newmainid)    {
    $oldmainid = "";
  }
?>

[bonsai99]

Thanks guys!

[PHPycho]

Better not to mess with PHP syntax at all. Just escape it

<?php
if ($row_rsModels)     {
?>
<SCRIPT type="text/javascript">
  var WAJA = new Array();
<?
  $oldmainid = 0;
  $newmainid = $row_rsModels["Make"];
  if ($oldmainid == $newmainid)    {
    $oldmainid = "";
  }
?>

Good point.
Don't mess any code like (javascript, css, html) with PHP.
Always make a separation with opening & closing tags like Shrapnel_N5 has presented.

[felgall]

You need to be extra careful when using script tags in pages being parsed by PHP to make sure that it can properly distinguish between

<script type="text/javascript">

and

<script language="php">