Issue with Loop foreach

[martinsandhu]

I'm trying to build an sql query using data that I have built in an array to filter the query on.

The issue I have is how do i remove the last OR statement once it has looped through all the values?

    $super_cats_id = '';
    
    foreach($data as $k=>$v)
    {
    
        $super_cats_id .= $v['SuperCatId'];
        $super_cats_id .= ' OR ';    
    }
    
    
    
    $sql            = "    Select * FROM Table WHERE id = ".$super_cats_id.""; 

Thanks

[Ize]

if ($k < (count($data)-1)) {
    $super_cats_id .= ' OR ';
} 

[Jake Arkinstall]

Or, a different approach:

$IDs = array(-1);
foreach($data as $Key=>$Value){
    $IDs[] = (int)$Value['SuperCatId'];
}
$IDsQueryPart = implode(', ', $IDs);
$sql = "Select Column1, Column2 FROM Table WHERE id IN({$IDsQueryPart})"; 

The initial -1 is there to stop the query having an empty IN(), which would throw an error. The bare minimum would be IN(-1), which should return nothing if no ID is -1. If that's a possibility, change -1 to an ID which can't be used.


Another approach, based on your current code, could be (though I'd rather the above...):

$super_cats_id = '';
foreach($data as $k=>$v){
    $super_cats_id .= ' OR id = '  . (int)$v['SuperCatId'];
}
$sql = "Select * FROM Table WHERE 1 = 0 {$super_cats_id}"; 

That will mean the query could be:

Select * FROM Table WHERE 1 = 0

(no results)

Select * FROM Table WHERE 1 = 0 OR id=1

(results)

[Mark Baker]

$super_cats_id = implode(', ',$data);
$sql = "Select * FROM Table WHERE id in ($super_cats_id)";

[Jake Arkinstall]

The data isn't a straight array of numbers, so the above wouldn't work.

Also note that:

SELECT something FROM atable WHERE id = 1 OR 2

Will fetch all the results - the equal sign is only applied to the 1, the 2 is a different clause. As 2 equates to 'true', what that is is effectively:

SELECT something FROM atable WHERE id = 1 OR true

which will always equate to true.

You need to either use the IN() function (recommended) or put ' id = ' infront of all of them.

[2473l33t]

Everyones solutions are good. But I have my own way of doing it.

Here is the answer to your original question. But that will
run you into problems as everyone suggests:

$super_cats_id = '';
foreach($data as $k=>$v)

    {
        $super_cats_id .= ($super_cats_id)? ' OR '. $v['SuperCatId']:$v['SuperCatId'];
    }

    $sql            = "    Select * FROM Table WHERE id = ".$super_cats_id.""; 

Now here is my solution

$super_cats_id = '';
foreach($data as $k=>$v)
    {
        $super_cats_id .= ($super_cats_id && $v['SuperCatId'])? ' , '. $v['SuperCatId']:$v['SuperCatId'];
    }    
  $sql            = "    Select * FROM Table WHERE id IN($super_cats_id)"; 

Well just another solution. Good luck!