Deletion

[Nitz89]

I'm trying to run a query in php, but i just get the error msg. I'm wondering what I might be doing wrong?

I am getting a specific dvd_id in a form, so I can delete that table row in the database.

$rowID = $_REQUEST["dvd_id"];


// Delete data in mysql from row that has this id
$sql="DELETE FROM dvds WHERE dvd_id='$rowID'";
$result=mysql_query($sql);
  
  
  // if successfully deleted
if($result){
echo "Deleted Successfully";

}

else {
echo "ERROR";
}

[Raju Gautam]

Try to see the physical query by echoing it after interpreting the variable $rowID.

echo $sql; 

Whether it does have the correct dvd_id or not.

Also try to see mysql's system error with:

mysql_query($sql) or die(mysql_error()); 

[spikeZ]

Further to rajug's answer, avoid using $_REQUEST as it is too random. Be specific where the incoming variable is from $_POST, $_GET etc but not $_REQUEST.

Also consider not deleting from your database but setup another field that has a simple boolean 0 or 1. 0 means its not displayed, 1 means it is. This saves a whole lot of problems with things being accidentaly deleted!

[Nitz89]

I'm wondering.. is the PEAR system different?

I am using the PEAR and mdb2 system....

require_once 'MDB2.php';

$dsn = 'mysqli://a4500_lab14:******@localhost/a4500_DVDRentals';

$mdb2 =& MDB2::connect($dsn);

if (PEAR::isError($mdb2)) {
  die($mdb2->getMessage());
}

//check to see if user wants to add
if (isset($_REQUEST["Add"])) 

{
 
//insert the record
if ( isset( $_REQUEST["customer_id"] ) ) {
  $sth = $mdb2->prepare( 'INSERT INTO customers (customer_id, fname, lname, city, phone, address, postal) VALUES (?, ?, ?, ?, ?, ?, ?)',
			 array('integer', 'text', 'text', 'text', 'integer', 'text', 'text' ),
			 MDB2_PREPARE_MANIP );
  $sth->execute( array( $_REQUEST["customer_id"],
			$_REQUEST["fname"],
			$_REQUEST["lname"],
			$_REQUEST["city"],
			$_REQUEST["phone"],
			$_REQUEST["address"],
			$_REQUEST["postal"] ) );
 }
 
 }
 
 
//check to see if user wants to remove
if (isset($_REQUEST["Remove"])) 

{
 //delete the record
 if ( isset( $_REQUEST["customer_id"] ) ) {
  $sth = $mdb2->prepare( 'DELETE FROM customers WHERE customer_id = $_REQUEST["customer_id"]');
            
}
}
$res =& $mdb2->query('SELECT * FROM customers');

?>

my delete code won't work properly.

[guido2004]

You don't execute the delete query

[vaibhavcoder]

yes please do not use $_Request[] use appropriate one

[Nitz89]

so how would you run the DELETE query then?

It seems a bit different on PEAR?

[guido2004]

How about:

if (isset($_REQUEST['customer_id'])) {
  $sth = $mdb2->prepare( 'DELETE FROM customers WHERE customer_id = $_REQUEST["customer_id"]');
  $sth->execute();            
}

I'm not sure, I never used PEAR. But the SELECT you do before the DELETE has a prepare and an execute statement, I imagine the same must be done for the DELETE