Method always returning false

[9three]

Hey,

I have a method that checks credentials and returns true if it matches.

public function loginUser($strUsername, $strPassword) {
    $result = $this->hDB->query("SELECT firstname, lastname, username, password, email, session 
                                 FROM user 
                                 WHERE username = '$strUsername' 
                                 AND password = '$strPassword'");
    if ($row = ($result->fetch_row()) == 1) {
      $this->firstname = $row->firstname;
      $this->lastname = $row->lastname;
      $this->username = $row->username;
      $this->passowrd = $row->password;
      $this->email = $row->email;
      $this->session = $row->session;
      
      return true;
    }
    return false;
  } 

The problem is that it always returns false. I thought fetch_row() would do the trick to check if there is a row that matches those credentials? But it's not working.

Looking for a hand

[felgall]

Try getting rid of the ==1 as the handle on the row is very unlikely to have that value.

[9three]

That works. I don't understand though. When I fetch a row, it's suppose to return a number?

[crmalibu]

nobody here but you knows what fetch_row() does, but it sure looks like it returns an object, not a number. Maybe you're thinking about a function or method that returns a count of how many rows the sql query produced.

[9three]

fetch_row() is from mysqli.

php manual says it returns a enumerated array.

[crmalibu]

Comparing an array to integer 1 is always going to be false.

Also, you would need to use $row[0] $row[1] etc... see the examples in the documentation. Or, see fetch_object() / fetch_assoc(), both of which are generally considered more useful than a numerically indexed array.