php update database with ajax

[deepM]

Hello,

I want to help with my code.i am just not able to find out that is it a php problem or java scripts.

viewf.php

<span>
 <a href="javascript: edit(<?=$row['id'];?>,<?=$row['friends'];?>);" title="edit">Edit</a></span>|

can i send something value like this in java script. i want to update my friends name so i need both id and friends value

edit.php

$id = $_REQUEST['id'];
$friends =$_REQUEST['friends'];
$query = "UPDATE  friends set friends='".$friends."' where id='$id'"; 

and my ajax.js

function edit(id,friends){
 
document.getElementById(id,friends).innerHTML = "<em>editing...</em>";
  alert("hello");
 
 
              http.open('GET', 'edit.php?id='+id+'&friends='+friends);
 	     http.onreadystatechange = insertReply1;
              http.send(null);
 
 
     }

can anyone help me with my code? now the status is record is getting empty as soon as i fire the query. i dont want to delete record but want to update it. it seems friends value is not getting passed through my JS.

thanks in advance

[Dan Grossman]

document.getElementById(id,friends).innerHTML = "<em>editing...</em>";

The only argument to document.getElementById is the ID attribute of an HTML element on the page. So "id,friends" doesn't make sense here.

[deepM]

thanks for your quick reply Dan Grossman,

you mean to say cant i send two id values in edit function?

if yes so i can use something like this right?

var site_url= encodeURI(document.getElementById('id').value);
var site_name = encodeURI(document.getElementById('friends').value);

[Dan Grossman]

No, I mean to say only what I said.

[deepM]

function edit(){
 
 document.getElementById('insert_response').innerHTML = "Updating...";
  alert("hello");
 var id= encodeURI(document.getElementById('id').value);
var friends = encodeURI(document.getElementById('friends').value);              
 
 
http.open('get', 'edit.php?id='+id+'&friends='+friends+'&nocache = '+nocache);
 
 	     http.onreadystatechange = insertReply;
              http.send(null);
 
 
     }

i have tried this but its not working... what is your suggestion?

[Dan Grossman]

You were passing in id and friends as parameters through a link, now you're reading them from the value property of some elements. Do those elements exist, are they the type to have value properties, and is their value the correct ID and string you want for the query?

[deepM]

is their value the correct ID and string you want for the query?

yes, i want to update my friends value.

Do those elements exist

yes, they exits on my viewf.php page like this

 $result =  $op->runsql("SELECT * FROM friends WHERE myid = '$userid' ORDER BY id ASC");


     $result1                = $op->runsql($result);
     $total_records         = mysql_num_rows($result1);
     $limit_value           = 10;
     $top                   = $total_records/$limit_value;
     $total_pages           = ceil($top);
     while($row = $op->select($result)){ ?>
 <input type="text" name="friends"   value="<?=$row['friends'];?>"  size="25" maxlength=15 /><span><a href="javascript: edit();" title="edit">Edit</a></span>|
<input type="hidden" name="id" value="<?=$row['id'];?>" id="<?=$row['id'];?>" /><span><a href="javascript:msgdelete(<?=$row['id'];?>);" title="Delete">Delete</a></span>
<? } ?>

are they the type to have value properties

dont know what does that mean

[Dan Grossman]

The ID attribute of those inputs should be "id" and "friends", not the name attribute.

[deepM]

<input type="text" name="friends"   value="<?=$row['friends'];?>" id="<?=$row['friends'];?>" size="25" maxlength=15 />
	 <input type="hidden" name="id" value="<?=$row['id'];?>" id="<?=$row['id'];?>" /><span>&nbsp;&nbsp; &nbsp;<a href="javascript: edit();" title="edit">Edit</a></span>|<a href="javascript:msgdelete(<?=$row['id'];?>);" title="Delete">Delete</a></span>

but here i have to use name attribute as id right because those value i want to pass.right?

[Dan Grossman]

document.getElementById('friends').value returns the value of an input with an *ID* of "friends". There is no such input. Change the ID on your two form elements. The ID attribute is supposed to be a unique identifier, not a value holder.

[deepM]

while deleting records i have sent id as

id="<?=$row['id'];?>"

and it's working fine. so i am bit confused when you said

The ID attribute is supposed to be a unique identifier, not a value holder

because id is holding its database value.

[Dan Grossman]

Perhaps, but your code is looking for an element with an ID of "friends", and no such element exists. We can talk in circles all day.

[deepM]

We can talk in circles all day.

not getting here what does that mean?

<input type="text" name="friends"   value="<?=$row['friends'];?>" name="friends1" id ="<?=$row['friends'];?>">

id for friends is much more exits in my code. while deletion i have to pass only one id. so it was easy but for updation i need both values what to change and where to change(where condition)

so i just want to know the method to pass two values into my JS function.please

[tmapm]

Deepson2, This may help: http://www.tizag.com/javascriptT/jav...lementbyid.php He's telling you that your id is wrong.

[Cups]

I want to help with my code.i am just not able to find out that is it a php problem or java scripts.

When trying to sort out where the fault lies with PHP/JS I developed this method.

Always write your JS by hand first with real values in a straight html file, and get that debugged and working first.

Then get your PHP backend handler to do what you expect it to do, use the GET method and just fiddle around with the values till you know it does exactly as you want.

Only when those 2 things are working should you try to get PHP to output the JS and link the two together.

Otherwise you will lose your mind (I did, 'till I made that rule up).

[deepM]

thnaks cups for your reply.

use the GET method and just fiddle around with the values till you know it does exactly as you want.

I am using GET method only. but the confusion comes when i need to pass two values. i think it creates conflict there. because i didnt find anything on net where pass two values using getelementid.

i will try to work on what you said. now the stutus is getting this:

idiot's not working[object HTMLDivElement]updation's not done

thanks tmapm,

your link was good. but i think its not useful for me. because i want to pass two values in URL using JS. anyways thakns.

can anyone help me.