php and js concat problem

[neel1979]

<SCRIPT LANGUAGE="JavaScript">
<!--
var ht = 100;
var wt = 100;
//-->
</SCRIPT>
<?php
$txt = "<a href=\"#\" onclick=\"javascript: window.open('". $mitem->link ."', '', 'toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width="+wt+",height="+ht+"'); return false\" class=\"$menuclass\" ". $id .">". $mitem->name ."</a>\n";
?>

When I am trying to concat ht and wt, the above code is giving error. What am I doing wrong?

Regards,
Nilanjan

[guido2004]

h="+wt+",height="+ht+"')

if it's javascript, escape the double quotes:

h=\"+wt+\",height=\"+ht+\"')

if it's PHP, use the dot as concatenation:

h=".wt.",height=".ht."')

[neel1979]

It's a JS concatenation within php. Please check this. It's not working.

<SCRIPT LANGUAGE="JavaScript">
<!--
wt=screen.availWidth;
ht=screen.availHeight;
//alert(wt);
//alert(ht);
//-->
</SCRIPT>
<?php
echo "<a href=\"#\" onclick=\"javascript: window.open('my-commitment.php', '', 'toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width=".wt.",height=".ht.",top=0,left=0'); return false\" >Click</a>\n";
?>

[Stormrider]

You can't just use javascript variables as though they were php constants like that, there is no way that can work unless wt and ht are php constants.

Why are you using php for this? If you want to include the javascript variables in the link, just use js alone.

[neel1979]

I have changed the code now. Please check.


<SCRIPT LANGUAGE="JavaScript">
<!--
wt=screen.availWidth;
ht=screen.availHeight;
//alert(wt);
//alert(ht);
//alert(wt+ht);
//-->
</SCRIPT>
<?php
echo "<a href=\"#\" onclick=\"javascript: window.open(\"my-commitment.php\", \"abc\", \"toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width=\" + wt + \",height=\" + ht + \",top=0,left=0\"); return false;\" >Click</a>";
?>

I am showing you part of the code. I can't use it with only JS. Please tell me what am I doing wrong here? Strangely popup is not opening.

[Stormrider]

Also you need to escape your quotes for javascript as well as php - php will just output the " which will make the html tag invalid. You need to 'double escape' some of those quotes.

[neel1979]

View source is showing the below code:

<SCRIPT LANGUAGE="JavaScript">
<!--
wt=screen.availWidth;
ht=screen.availHeight;
//alert(wt);
//alert(ht);
//alert(wt+ht);
//-->
</SCRIPT>
<a href="#" onclick="javascript: window.open("my-commitment.php", "abc", "toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width=" + wt + ",height=" + ht + ",top=0,left=0"); return false;" >Click</a>

Can you please rewrite the right code?

[guido2004]

If you want to know the right JS syntax to put the value of a JS variable in the onclick event, you'd better ask in the JS forum.
If you already know the correct syntax, but are having problems creating it with PHP, then just post the correct syntax here, and we'll show you how to write the PHP echo command.

[neel1979]

Is there someone who can tell me what I have done wrong in this code. If I know the correct syntax then why should I post it here?

[guido2004]

Is there someone who can tell me what I have done wrong in this code. If I know the correct syntax then why should I post it here?

I thought I was quite clear in my explanation, but I guess not
"Here" is the PHP forum. It seems to me your problem is not PHP, but the correct syntax of a JS command. If this is correct, then you'd better ask your question in the JS forum.

Something like

Why doesn't this code work?

<SCRIPT LANGUAGE="JavaScript">
<!--
wt=screen.availWidth;
ht=screen.availHeight;
//alert(wt);
//alert(ht);
//alert(wt+ht);
//-->
</SCRIPT>
<a href="#" onclick="javascript: window.open("my-commitment.php", "abc", "toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,widt h=" + wt + ",height=" + ht + ",top=0,left=0"); return false;" >Click</a>

If you already know the exact syntax of the JS code you need, but you can't get PHP to create it for you, then post the JS code you need here, and we'll help you write the PHP code that will create that JS code.

Until know you didn't post the correct JS code. You only posted the result of your PHP command, which is working fine. But the result is not what you want. I'm no JS expert, so unless you give me the correct JS, I won't be able to help you with the PHP part.

[Salathe]

From the code you have posted so far, there is no requirement for the HTML to be written via PHP and echo. However, if you really do want the code as you've posted so far:

<SCRIPT LANGUAGE="JavaScript">
<!--
wt=screen.availWidth;
ht=screen.availHeight;
//alert(wt);
//alert(ht);
//alert(wt+ht);
//-->
</SCRIPT>
<?php

echo '<a href="#" onclick="window.open(\'my-commitment.php\', \'abc\', \'toolbar=no,location=no,status=no,menubar=no,scrollbars=yes,resizable=yes,width=\' + wt + \',height=\' + ht + \',top=0,left=0\'); return false;">Click</a>';

?>

The JavaScript code within the onclick attribute could not contain double-quotes as that would close the attribute string prematurely. HTML doesn't have a concept of escaping quotes (ie, onclick="myfunc(\"blah\")" wouldn't work (the onclick value would be myfunc(\ only)). To that end, I've made the HTML use double quotes and the JavaScript use single quotes. Now, since the PHP is echoing a single-quote-delimited sting then the JavaScript's single quotes need to be escaped (once only) in order to make the string valid PHP syntax.

Finally, this would have been a whole lot simpler (and prettier) if you wanted to use nice HTML/JavaScript code in the first place.