dynamic comparison

[noddy]

I have a list of servers which I am checking the time period for which they last reported an update. Based on the period they are classified at different levels of online and off line states.

I have these three vars which I need to evulate through an if statement. Based on the one to pass I will know at what status the server is.

Here is my three vars

$updated_timstamp $status_indicator->getComparison() $timestamp 

Which is actually something like

2009-03-31 20:35:02 >= 2009-03-31 20:33:34

However when it is placed in an if like so

 if ($updated_timstamp $status_indicator->getComparison() $timestamp) 

it never gets into the if and so the code I need to execute fails. I don't think it even runs.

I have tried to eval the code but nothing I have tried works.

Can anyone tell me what I need to do in order to complete what I am trying to achieve.

[jeffvdovjak]

I'm not entirely sure what your code is trying to do here - but I'm going to take a guess (I have two ideas).

If you are trying to use an operator from a variable PHP allows that - you should be getting an error. (as in you can't store the ">=" as a variable to be used as an operator). You'd have to use nested if statements for each possible operator, or use switch statements. As in:

if($status_indicator->getComparison() == ">="){
    if($updated_timestamp >= $timestamp) {
        //do something
    } else {
        //do something else
    }
} elseif($status_indicator->getComparison() == "<=") {
    if($updated_timestamp <= $timestamp) {
        //do something
    } else {
        //do something else
    }
} else {
//... ect...

You could use a switch statement too which would probably make it easier to read. Or you could probably come up with a better solution (but I'm not entirely sure this is what you're trying to accomplish).

[noddy]

I think your solution is the one I will have to go with. I know the comparison will have to be one of the comparison operators so I guess I can use a switch on all of them until I get a match then perform the comparison.

It's not pretty but I guess it will work.

Been think about it for days so thank you for your suggestion.

[jeffvdovjak]

no problem. you could use ternary operators - but that would probably just make it more complicated and harder to read since you'll have many options. But using a switch will make the code easy to understand.

[noddy]

This is the error thats being generated for the comparison operator variable.

Notice: Undefined property: StatusIndicator::$getComparison in /home/nathanr/public_html/hopcon_serverdb/code/lib/task/checkCurrentStatusTask.class.php on line 93 

[jeffvdovjak]

I'd have to see your code to be able to offer any help - but I'm guessing it's because you haven't instantiated the object or set the variable...

[crmalibu]

That's because your object doesn't have such a property. Maybe you meant to call a method, but made a typo?

[noddy]

Thee full source

<?php

class checkCurrentStatusTask extends sfBaseTask
{
  
  protected function configure()
  {
    // // add your own arguments here
    // $this->addArguments(array(
    //   new sfCommandArgument('my_arg', sfCommandArgument::REQUIRED, 'My argument'),
    // ));

    $this->addOptions(array(
      new sfCommandoption('application', null, sfCommandOption::PARAMETER_REQUIRED, 'the application that this is running as', 'webmaster'),
      new sfCommandOption('env', null, sfCommandOption::PARAMETER_REQUIRED, 'The environment', 'dev'),
//      new sfCommandOption('connection', null, sfCommandOption::PARAMETER_REQUIRED, 'the connection name', 'propel'),
//      new sfCommandOption('connection', null, sfCommandOption::PARAMETER_REQUIRED, 'the connection name', 'propel'),
      new sfCommandOption('verbose', null, sfCommandOption::PARAMETER_REQUIRED, 'Enables verbose output', false),
      // add your own options here
    ));

    $this->namespace        = 'hopcon';
    $this->name             = 'check-current-status';
    $this->briefDescription = 'This task will check on the current stauts of servers and notify the required people whe the status changes';
    $this->detailedDescription = <<<EOF
The [checkCurrentStatus|INFO] task will check on the current stauts of servers and notify the required people whe the status changes.
Call it with:

  [php symfony checkCurrentStatus|INFO]
EOF;
//
//    
//    $this->addArgument('application', sfCommandArgument::REQUIRED, 'webmaster');
//    $this->addOption('verbose', null, sfCommandOption::PARAMETER_REQUIRED, 'Enables verbose output', false);
//    $this->addOption('connection', null, sfCommandOption::PARAMETER_REQUIRED, 'The connection name', 'propel');
//    $this->addOption('env', null, sfCommandOption::PARAMETER_REQUIRED, 'The enviroment', 'dev');
  }

  protected function execute($arguments = array(), $options = array())
  {
    // initialize the database connection
    $databaseManager = new sfDatabaseManager($this->configuration);
//    $connection = $databaseManager->getDatabase($options['connection'] ? $options['connection'] : '')->getConnection();
    
//    $databaseManager = new sfDatabaseManager($configuration);
    

//    echo "connection: ".print_r($connection, true)."\n";
//    echo "databaseManager: ".print_r($databaseManager, true)."\n";
//    echo "configuration: ".print_r($this->configuration, true)."\n";
    
//    mail('nathan@lionslair.net.au', 'debug', print_r($this->configuration, true));
    
    

    // add your code here
    
    /*
     * Get all current status's
     */
    $server_users = ServerUsersPeer :: doSelect(new Criteria());
    
//    echo print_r($server_users, true);
    
    $status_indicators = StatusIndicatorPeer :: getAll();
    
    
    
    /*
     * Only continue if there are server_users
     */
    if ($server_users)
    {

      /*
       *  for each of records
       */
      foreach ($server_users as $server)
      {
        
        
        if ($status_indicators)
        {
          foreach ($status_indicators as $status_indicator)
          {
            /*
             * find the match
             */
            $timestamp = date(sfConfig::get('app_date_format_save'), strtotime("-".$status_indicator->getPeriod()." minutes"));
            $updated_timstamp = ServerUsersPeer :: getUpdatedAtByServerKey($server->getServerKey());
//            $value = eval("\$updated_timstamp \$status_indicator->getComparison() \$timestamp");
//            $value = $updated_timstamp.' '.$status_indicator->getComparison().' '.$timestamp;
            $value = "$updated_timstamp $status_indicator->getComparison() $timestamp";
//            $compare = constant($status_indicator->getComparison());
//           echo 'value: '.$value."\n";
//           echo 'comparison: '.$status_indicator->getComparison()."\n";

//            echo 'status_indicator: '.print_r($status_indicator, true).'\n';
            if ($updated_timstamp $status_indicator->getComparison() $timestamp)
            {

                // ok now send the email or what ever
//               echo print_r(sfConfig :: get('app_mailer_defaults'), true);  
              
//                  nahoMail::send('My subject', 'My body', 'recipient@mail.com');

               ServerStatusLogPeer :: add($server->getId(), $status_indicator->getId());
                
              
            }

          } // end foreach
        } // end if
        
        
      } // end foreach 
    } // end if
    
    
    
    
  } // end function execute
}

[jeffvdovjak]

It's extending another class - so it's calling from code we can't see.


This looks like it's going to be a long debugging project.

[crmalibu]

That code won't produce such an error message. It will result in a parse error, failing to even execute.