Ruby on rails - help with an active record query

[TFDM]

Hi guys.

I'm still at the early stages of learning so be gentle. However I used want to ask a question about an active record query I am trying to run.

I have set up a table for my users and have populated in, created the model and I can queries against it. I now want the user to be able to visit http://localhost/profile/show/1 (1 being the user_id) and show the stories they have entered. This also has a model and is working properly as I have constructed an index page which lists recent articles and another page which shows them.

However I can't get the articles for a selected user to appear on the profile page.

My code is below...

class ProfileController < ApplicationController

  def show
  	@user = User.find(params[:id])
	@stories = Story.find :all, :conditions => "user_id = params[:id]"	
  end
  
end

And...

<h1>Profile</h1>
<p><%= @user.name %></p>

<% for story in @stories %>
	<%= story.headline %>
<% end %>

Thanks in advance.

[scannon]

Well, I don't know how your associations are set up but you should be able to do something like this in your show method:

@stories = user.stories

And then use your view just like you have it.

[TFDM]

Thanks for the reply. I added @stories = @user.stories to my controller and it worked. However I think it needs to be part of a query as I want to order then my most recent.

I've included my models below and I think I've set the relationship up correctly.

class Story < ActiveRecord::Base
	belongs_to :user
end

class User < ActiveRecord::Base
	has_many :stories
end

[ReggieB]

The has_many options are listed in the Rails api:

http://api.rubyonrails.org/classes/A...s.html#M001789

You can do this:

class User < ActiveRecord::Base
	has_many :stories, :order => 'created_at DESC'
end

However, that will return the stories in that order every time you use user.stories. If you only needed them ordered that way on some occasions you could create a custom method in the User model. Something like this for example:

class User < ActiveRecord::Base
  def stories_by_created_at
    Story.find(:all, 
          :conditions => ['user_id = ?', self],
          :order => 'created_at DESC')
  end
end

@stories = @user.stories_by_created_at

[scannon]

I posted a solution that was the same as Reggie's. His will work great!

[devbanana]

I'm pretty sure the problem is just that your variable isn't being interpreted. Replace the Story.find line with this:

@stories = Story.find :all, :conditions => "user_id = #{params[:id]}"

[TFDM]

Thanks guys. Will try when I get back to the office on Monday morning and let you know how I get on.

[TFDM]

Thanks very much guys for your help. In the end this got it working.

@stories = Story.find :all, :conditions => "user_id = #{params[:id]}", :order => 'date_added DESC'

[ReggieB]

I'd recommend you change:

@stories = Story.find :all, :conditions => "user_id = #{params[:id]}", :order => 'date_added DESC'

to

@stories = Story.find(:all, :conditions => ["user_id = ?", params[:id]], :order => 'date_added DESC')

The form you've used is susceptible to SQL injection attacks.

Personally, I'd use:

if params[:id] and user = User.find(params[:id])
  @stories = Story.find(:all, conditions => ["user_id = ?", user], :order => 'date_added DESC')
else
  #Some code that caught the fact that an invalid user id has been passed to the page
end

That way the user id is only used if a matching user can be found.

[TFDM]

Thanks for the info.