Why is this link opening code wrong?

[jmsherry]

I'm trying to write a cold which takes all the links in the page (within the content div) and sets their onclick to open in a new window...

I can't see why it wouldn't work...

Any takers???

function linkBehaviour() {
	for (var j=0; j<document.getElementById(content).anchor.length; j++) {
	document.anchors[j].onclick = window.open(this.href);
		return true;
		}
}

[Dan Grossman]

A couple problems...

1) I don't think .anchor gives you back a list of anchor elements that are children of that div, but I haven't tried that

2) document.anchors is not the same array as document.getElementById(content).anchor, so you can't index into it in that order. You're editing arbitrary links in the document, regardless of whether they're within your #content div or not.

3) I think you want document.anchors[j].href, not this.href, to reference the href of the anchor you're changing the onclick value of in that loop

[jmsherry]

Dan,

Thanks for your reply...I'm going to re-edit using what you've said, and repost when I have something...

Jim