Download class works fine, except for images

[azz0r_wugg]

Which it gives out a red x in the temp files it shows up (in ie8).

<?php
 
 
class Download {
 
 
	public $path 				= NULL;
	public $contentType 		= NULL;
	public $contentDisposition 	= NULL;
 
 
	function __construct($path, $filename) {
		$this->path 				= $path;
		$this->filename				= $filename;
		$this->contentType 			= mime_content_type($path);#$contentType;
		$this->contentDisposition 	= "attachment";#$contentDisposition;
	}
 
 
	public function Exists() {
 
		if (file_exists($this->path)) { 
			return true;
		} else {
			return false;
		}
	}
 
 
	public function Size() {
 
		if ($this->Exists()) {
			return filesize($this->path);
		} else {
			return false;
		}
	}
 
 
	public function Permit_Other() {
		return substr(decoct(fileperms($this->path)), -1);
	}
 
 
	public function Init() {
 
		if ($this->Exists() && $this->Permit_Other() >= 4) {
			header("Content-type: ".$this->contentType);
			header("Content-Disposition: ".$this->contentDisposition."; filename=\"".$this->filename."\"");
			header("Content-Length: ".$this->Size());
			$fp = readfile($this->path, "r");
			return $fp;
		} else { 
			return false;
		}
	}
 
 
}
 
 
?>

Help?

[Trent Reimer]

A couple trouble shooting questions:

1. If you have the program return just the headers (as text) instead of the file, does it say what you expect?
2. Are you saying those same images show up in Firefox?

[azz0r_wugg]

Firefox downloads a broken image. IE opens up a broken image.

PDF works fine, which is important, but occasionally it needs to display images.

[Trent Reimer]

Thanks. I noticed on the PHP "readfile" page that the argument "r" is not necessary and that they gave the Content-Type header as "application/octet-stream" for all attachments.

http://www.php.net/readfile

[azz0r_wugg]

I have updated the Init function. I still have the same issue: PDF work fine and images come corrupt.

    public function Init() {

        if ($this->Exists() && $this->Permit_Other() >= 4) {
            #header("Content-type: ".$this->contentType);
            #header("Content-Disposition: ".$this->contentDisposition."; filename=\"".$this->filename."\"");
            #header("Content-Length: ".$this->Size());
            #$fp = readfile($this->path, "r");
            #return $fp;

            ob_start();
            header("Cache-Control: public, must-revalidate");
            header("Pragma: no-cache");
            header("Content-Description: File Transfer");
            header('Last-Modified: '.date('r'));
            header('Content-type: '.$this->contentType);
            header("Content-Disposition: ".$this->contentDisposition."; filename=".$this->filename.";");
            header("Content-Transfer-Encoding: binary");
            header("Content-Length: ".$this->Size());
            ob_flush();
            exit();
        } else { 
            return false;
        }
    } 

[Trent Reimer]

<?php

class Download
{
    public $path                = NULL;
    public $contentType         = NULL;
    public $contentDisposition  = NULL;


    public function __construct($path, $filename)
    {
        $this->path                = $path;
        $this->filename            = $filename;
        $this->contentType         = mime_content_type($path);#$contentType;
        $this->contentDisposition  = "attachment";#$contentDisposition;
    }


    public function Exists()
    {

        if (file_exists($this->path)) {
            return true;
        } else {
            return false;
        }
    }


    public function Size()
    {

        if ($this->Exists()) {
            return filesize($this->path);
        } else {
            return false;
        }
    }


    public function Permit_Other()
    {
        return substr(decoct(fileperms($this->path)), -1);
    }


    public function Init()
    {

        if ($this->Exists() && $this->Permit_Other() >= 4) {
            header("Content-type: ".$this->contentType);
            header("Content-Disposition: ".$this->contentDisposition."; filename=\"".$this->filename."\"");
            header("Content-Length: ".$this->Size());
            readfile($this->path);
            exit;
        } else {
            return false;
        }
    }
}

[azz0r_wugg]

Still corrupt. I've gone for a different solution, not ideal but i don't have much more time to work on this. Means to an end.

<?php


class Download {


    public $path                 = NULL;
    public $contentType         = NULL;
    public $contentDisposition     = NULL;


    function __construct($path, $filename) {
        $this->path                 = $path;
        $this->filename                = $filename;
        $this->contentType             = mime_content_type($path);#$contentType;
        $this->contentDisposition     = "attachment";#$contentDisposition;
    }


    public function Exists() {

        if (file_exists($this->path)) { 
            return true;
        } else {
            return false;
        }
    }


    public function Size() {

        if ($this->Exists()) {
            return filesize($this->path);
        } else {
            return false;
        }
    }


    public function Permit_Other() {
        return substr(decoct(fileperms($this->path)), -1);
    }


    public function Init() {

        if ($this->Exists() && $this->Permit_Other() >= 4) {
            if (ereg ("^image", $this->contentType)) {
                echo '<img src="'.SITE_URL.$this->path.'" alt="" title="" />';
                exit();
            } else {
                ob_start();
                header("Cache-Control: public, must-revalidate");
                header("Pragma: no-cache");
                header("Content-Description: File Transfer");
                header('Last-Modified: '.date('r'));
                header('Content-Type: '.$this->contentType);
                header('Content-Disposition: '.$this->contentDisposition.'; filename="'.$this->filename.'"');
                header("Content-Transfer-Encoding: binary");
                header("Content-Length: ".$this->Size());
                readfile($this->path);
                ob_flush();
                exit();
            }
        } else { 
            return false;
        }
    }


}


?>

[Trent Reimer]

That's strange, it worked for me. Is there a file name conflict?

[adguru.org]

You are doing it in Windows or Linux or may be Mac? This is very important to understand because I faced the same problem, in windows my Images were fine but in Linux they were distorted. I was configuring script called VieleRETS

[Trent Reimer]

You are doing it in Windows or Linux or may be Mac? This is very important to understand because I faced the same problem, in windows my Images were fine but in Linux they were distorted. I was configuring script called VieleRETS

That's a good thing to consider. I was using Ubuntu Linux.

I didn't mean to sound insulting with my last question, it's just that sometimes anyone will make a typo. For example, if I do something like

$download = new Download('picture.gif', 'picture.jpg');
$download->Init(); 

The image will download but if I try to open the image with an application it doesn't necessarily know what to do with it as it may be looking at the file name extension.

[azz0r_wugg]

It finds the image definetely, it was just serving it corrupt.

I think we're on Windows machines. The current solutions fine, I've been given my next project so I can't really fix this any further.

[AnthonySterling]

I would guess you have erroneous white space located in your image data, other files are little more forgiving in my experience with this issue.

Try this:-

header("Cache-Control: public, must-revalidate");
header("Pragma: no-cache");
header("Content-Description: File Transfer");
header('Last-Modified: '.date('r'));
header('Content-Type: '.$this->contentType);
header('Content-Disposition: '.$this->contentDisposition.'; filename="'.$this->filename.'"');
header("Content-Transfer-Encoding: binary");
header("Content-Length: ".$this->Size());
ob_start();
readfile($this->path);
$sFileData = ob_get_contents();
ob_end_clean();
echo $sFileData;
exit(); 

[azz0r_wugg]

That didnt work either.

The image in question is: http://v2.myvouchercodes.co.uk/publi...hers/46222.png

but all images come out broken anywho

[AnthonySterling]

Is this file local or remote?

[azz0r_wugg]

Remote, it would be local to the script though.