problem with recursion

[jjshell]

Hi,

I have tried numerous times to refactor the code below, but it sucks... and the version here is the best I could came up with.

Could you please help me refine it and provide advice?

  public function getCars()
  {

    $this->listOfCars= '';
    
    $this->buildListOfCars($this->allTheCars);//turns array into string
    
    return $this->listOfCars;//a string

  }
  
  protected function buildListOfCars($allTheCars)
  {

    
    foreach($allTheCars as $cars){
      
      if(is_array($cars)){
        $this->buildListOfCars($cars);
      }
      
      $this->listOfCars.= $cars;

    }
  
  } 

Asd you can see, it's impossible to say if data will be an array, or a string I can add to my list of cars string.

Regards,

-jj.

[crmalibu]

You can't concatenate an array to a string(well, and get a useful result that is)

      if(is_array($cars)){ 
        $this->buildListOfCars($cars); 
      } else {
       // scalar, concat ok
      $this->listOfCars.= $cars;
} 

[crmalibu]

You might consider just making the array 1 dimensional

function array_flatten($array) {
    $flat = array();
    foreach ($array as $element) {
        if (is_array($element)) {
            $flat = array_merge($flat, array_flatten($element));
        } else {
            $flat[] = $element;
        }
    }
    return $flat;
}

echo implode(',', array_flatten($nested_arrays));