converting php5 to php4

[KirstyBurgoine]

I've got a currency converter script that works perfectly in php5, however, when I went to add it to a clients site. That site sits on a server that runs php4. The client doesn't want to upgrade at the moment so I have to find a way to get this to work.

This is the original script {

class YahooFinanceConverter
{
	CONST YAHOO_URL = 'http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X';

	public static function yahoo_convert($a,$from,$to)
	{
		$fo = @fopen(sprintf(self::YAHOO_URL,$from,$to), 'r');
		if ($fo)
		{
			$response = fgets($fo, 4096);
			fclose($fo);
			$array = explode(',',$response);
			if(strval($array[1]) > 0) { return strval($a)*strval($array[1]); }
		}
		return false;
	}

}

$rates = YahooFinanceConverter::yahoo_convert(10,'USD','GBP');
if($rates===false) {
	echo "Can't process the conversion";
} else {
	echo number_format($rates,4);
}

and this is what I have changed it to so far:

define('YAHOO_URL','http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X');

class YahooFinanceConverter
{
	
	
	function YahooFinanceConverter () 
	{
	$this -> YAHOO_URL = 'http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X';
	}
	
	function yahoo_convert($a,$from,$to)
	{
		$fo = @fopen(sprintf(YAHOO_URL,$from,$to), 'r');
		if ($fo)
		{
			$response = fgets($fo, 4096);
			fclose($fo);
			$array = explode(',',$response);
			if(strval($array[1]) > 0) { return strval($a)*strval($array[1]); }
		}
		return false;
	}

}

$rates = new YahooFinanceConverter::yahoo_convert(10,'USD','GBP');
if($rates==false) {
	echo "Can't process the conversion";
} else {
	echo number_format($rates,4);
}

Unfortunately this gives me the error:
Parse error: parse error, unexpected T_PAAMAYIM_NEKUDOTAYIM in /home/httpd/vhosts/robertharrop.com/httpdocs/CurrencyConverter.php on line 29

I know the error is because of :: in
$rates = new YahooFinanceConverter::yahoo_convert(10,'USD','GBP');

but, as I know nothing about classes I have no real idea how to fix it. Can anyone help?

Thanks
Kirsty

[Raju Gautam]

I guess something like this should work:

class YahooFinanceConverter
{
    var $_yahoo_url = 'http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X';

    function yahoo_convert($a, $from, $to)
    {
        $fo = @fopen(sprintf($this->_yahoo_url, $from, $to), 'r');
        if ($fo)
        {
            $response = fgets($fo, 4096);
            fclose($fo);
            $array = explode(',',$response);
            if(strval($array[1]) > 0) { return strval($a)*strval($array[1]);}
        }
        return false;
    }

}
$obj = new YahooFinanceConverter;
$rates = $obj->yahoo_convert(10,'USD','GBP');
if($rates === false){
    echo "Can't process the conversion";
}else{
    echo number_format($rates, 4);
} 

[kyberfabrikken]

$rates = new YahooFinanceConverter::yahoo_convert(10,'USD','GBP'); 

Should be:

$rates = YahooFinanceConverter::yahoo_convert(10,'USD','GBP'); 

[Raju Gautam]

And also this line in the constructor?

$this -> YAHOO_URL = 'http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X'; 

When you fix the problem suggested by kyberfabrikken, I think next error will be in this line since the YAHOO_URL is not defined as the member variable of the class.


And AFAIK you dont need the constructor to assign the Yahoo URL because you have already defined the constant YAHOO_URL.

Edit:
Ahh..
That actually did not give any error when I checked. I am in PHP 5.2.8. Is the the right behavior kyberfabrikken?? I am not certain on this .

[KirstyBurgoine]

Hi,
Thanks for your help so far guys.

I tried the top piece of code but it echoed 'Can't process the conversion'.

So I went back to my code and changed the $rates line back to:

$rates = YahooFinanceConverter::yahoo_convert(10,'USD','GBP'); 

I then added:

var $YAHOO_URL;

above this line

function YahooFinanceConverter ()

But this still echoes 'Can't process the conversion'

My entire code looks like:

class YahooFinanceConverter
{
	
	var $YAHOO_URL;
	function YahooFinanceConverter () 
	{
	$this -> YAHOO_URL = 'http://finance.yahoo.com/d/quotes.csv?e=.csv&f=sl1d1t1&s=%s%s=X'; 
	}
	
	function yahoo_convert($a,$from,$to)
	{
		$fo = @fopen(sprintf(YAHOO_URL,$from,$to), 'r');
		if ($fo)
		{
			$response = fgets($fo, 4096);
			fclose($fo);
			$array = explode(',',$response);
			if(strval($array[1]) > 0) { return strval($a)*strval($array[1]); }
		}
		return false;
	}

}

$rates = YahooFinanceConverter::yahoo_convert(10,'USD','GBP'); 
if($rates==false) {
	echo "Can't process the conversion";
} else {
	echo number_format($rates,4);
}

[imaginethis]

$fo = @fopen(sprintf(>>>>>>YAHOO_URL<<<<<<,$from,$to), 'r');

$fo = @fopen(sprintf($this->YAHOO_URL,$from,$to), 'r'); 

[KirstyBurgoine]

Just realised I need to change my php.ini to 'allow_url_fopen'

Will let you know.....

[cranial-bore]

You are calling YahooFinanceConverter as a static class, which means the constructor won't run, which means $YAHOO_URL won't be defined.

Try this:

$yfc = new YahooFinanceConverter();
$rates = $yfc -> yahoo_convert(10, 'USD', 'GBP');
if($rates === false) {
    echo "Can't convert. I reckon it's probably about £6.80 though";
}
else {
    echo number_format($rates, 4);
}