Foreach loop displays extra empty row

[Aidin]

Would like to prevent the extra blank row from appearing in this loop.

$swarray=explode(";", $swarray);
    foreach ($swarray as $rrow) {
    $row=explode(":", $rrow);
echo "
    var divId = 'imageColor_".$row[0]."';
    if (divId == idToHighlight && MouseOver==1) {
        if(SelectedAsDefault){
            changeImgBorder(divId, \"1px solid #bdbdbd\",".$row[0].");
                        
        }else{
            if(divId != SelectedDefaultSwatchImgId)
                changeImgBorder(divId, \"1px solid #bdbdbd\",".$row[0].");
                changeDefaultColor('$row[1]');
            }    
            
    } else {
        if (SelectedDefaultSwatchImgId != undefined && SelectedDefaultSwatchImgId != '')
        {
            if (!MouseOver)
            {
                changeDefaultColor(SelectedDefaultSwatchColorName);
            }
            if(divId != SelectedDefaultSwatchImgId)
            {
                //original border
                changeImgBorder(divId, \"0px solid\",".$row[0].");
                
            }
        }
    } ";

} 

[triexa]

What is the value of $swarray before you explode it?

[Aidin]

1:White Vinyl:wv:1;2:Black Vinyl:bv:0;3:Silver Vinyl:sv:0;4:Brown Ultrasuede:bru:0;5:Orange Ultrasuedeu:0;6:Blue Ultrasuede:blu:0;7:Green Ultrasuede:gu:0;

[bhanson]

$swarray=explode(";", $swarray, -1); 

[triexa]

IF you are going to MAYBE have a semicolon at the beginning too, you may want to consider running it through trim($swarray, ';'); first

[triexa]

$swarray=explode(";", $swarray, -1); 

I never knew about the negative third parameter.. I always pre-processed the string

Learn something new every day!

[Aidin]

Thanks that worked

[Sabia Design]

foreach($swarray as $rrow){
    if(empty($rrow)) continue;
    (rest of foreach loop)
}

[triexa]

foreach($swarray as $rrow){
    if(empty($rrow)) continue;
    (rest of foreach loop)
}

Not the most efficient - you're running the check every single loop. When you know its just the last element you don't want, this is not the route to take

[Sabia Design]

Not the most efficient - you're running the check every single loop. When you know its just the last element you don't want, this is not the route to take

If you know that your last element is empty then you can use "-1" to remove that last element.

However, that seems only useful when "'exploding" a string into an array. If you have an array that you want to skip all empty elements, then "continue" is more efficient.