form submission and return false

[bradical1379]

I have a small search appliance on my site that uses the following HTML:

<form action="/search/search.aspx" method="post" onsubmit="siteSearch(this);">
<input name="q" id="searchbox" type="text" value="Search...">
<input type="hidden" id="search-url" value="/search/search.aspx"> 
<input type="submit" class="search" name="submit" id="search-submit" value="GO">
</form>

And I use this javascript (with jquery) on the submission:

function siteSearch(form) {
	var q = $("#searchbox").attr("value");
	var url = $("#search-url").attr("value");
	if (q == "Search...") {
	    alert("Please enter search criteria.");
	    return false;
	}
    form.action = url + "?q=" + q;
    return true;
}

I am attempting to create a stop in the form action if someone leaves the input blank or with the predefined "Search..." however, once the alert pops up and a user presses "OK" it still attempt to submit the form.

Any ideas on how to stop the action in the form?

[ferrari_chris]

I have a small search appliance on my site that uses the following HTML:

<form action="/search/search.aspx" method="post" onsubmit="return siteSearch(this);">
<input name="q" id="searchbox" type="text" value="Search...">
<input type="hidden" id="search-url" value="/search/search.aspx"> 
<input type="submit" class="search" name="submit" id="search-submit" value="GO">
</form>

...

Try that. I've added return to the onsubmit.

Your code looks alright to me. When I'm doing Javascript form validation I always have the return there so see if that works for you.

[paul_wilkins]

Yes, you need the return so that the value returned from the function is itself returned to the form.