simple count query

[pwesthead]

Hi ian trying to do a simple count query, when a member has posted, lets say 50 images, i want to take them to a order page, i have written this code below but freezes the browser,

  $totalcount = 0;
        $query = "SELECT count(*) as total from images where userid='$userid' ";        
   $result = mysql_query($query) or die("Query failed.");    
   while ($row = mysql_fetch_array($result))

{

$total=$row[total];
}


if($total>25)
 header('Location: order.php');   

 exit(); 

[lorenw]

try

$result = mysql_query("SELECT id FROM images where userid='$userid' ");  
$row = mysql_fetch_array( $result );
$total = mysql_numrows($result); 

[crmalibu]

Your origional code is correct.

Try replacing the header() with var_dump($total);
Do you get the expected output? Remember, you must send headers before sending any output. You can read the documentation for the header() function for more info.

[r937]

lorenw, that is probably the most inefficient method possible

[AnthonySterling]

You are trying to access the returned array incorrectly, you requested an array be returned rather than an associative array.

<?php
$sSQL = sprintf("SELECT COUNT(*) AS total FROM images WHERE userid = %s",
    (Integer)$userid
);
$rResult = mysql_query($sSQL);
while($aRow = mysql_fetch_assoc($rResult))
{
    $iNumberOfImages = $aRow['total'];
}
if($iNumberOfImages > 25)
{
    header('Location: http://www.yourserver.com/order.php');
    exit;
}
?>

[crmalibu]

* mysql_fetch_array() returns both numerically and associative indexed. So it will work, it's just ever so slightly wasteful.

[AnthonySterling]

*whistles*

Wow, that goes in my 'things I learnt today' book.

[guido2004]

Since your query returns only one line, there is no need for a while-loop.

[lorenw]

r937, I will read and learn from this thread. I'm glad I posted that so I don't do it that way anymore. I usually use mysql_numrows($result); for checking if no results are returned from the database do this else do that. Is this a wrong thing?

Thanks

[pwesthead]

Hi
i have tried your code SilverBulletUK but it still freezes the browser