Help needed, function not working

[eparkila]

I am wondering if anyone can help tell me why the second function, getByUsername, does not work when the other function works perfectly. I have listed the code below, thanks in advance!

//return an object populated based on the record's user id
public static function getById($user_id)
{
    $user = new User();
    $query = sprintf('SELECT FIRST_NAME, LAST_NAME,   USERNAME, PASSWORD, EMAIL_ADDR IS_ACTIVE ' . 'FROM %sUSERS WHERE USER_ID = %d', DB_TBL_PREFIX, $user_id);

    $result = mysql_query($query, $GLOBALS['DB']);
    if (mysql_num_rows($result))
    {
    $row = mysql_fetch_assoc($result);
    $user->first_name = $row['FIRST_NAME'];
    $user->last_name = $row['LAST_NAME'];
    $user->username = $row['USERNAME'];
    $user->password = $row['PASSWORD'];
    $user->emailAddr = $row['EMAIL_ADDR'];
    $user->isActive = $row['IS_ACTIVE'];
    $user->uid = $user_id;
     }
    
    mysql_free_result($result);
    return $user;
}


//retun an object populated based on the record's username
public static function getByUsername($username)
{
    $user = new User();
    $query = sprintf('SELECT USER_ID, FIRST_NAME, LAST_NAME, PASSWORD, EMAIL_ADDR, IS_ACTIVE ' .  'FROM %sUSERS WHERE USERNAME = "s%"', DB_TBL_PREFIX, mysql_real_escape_string($username, $GLOBALS['DB']));

$result = mysql_query($query, $GLOBALS['DB']);
if (mysql_num_rows($result))
{
             $row = mysql_fetch_assoc($result);
    $user->first_name = $row['FIRST_NAME'];
    $user->last_name = $row['LAST_NAME'];
    $user->username = $username;
    $user->password = $row['PASSWORD'];    
    $user->emailAddr = $row['EMAIL_ADDR'];
    $user->isActive = $row['IS_ACTIVE'];
    $user->uid = $row['USER_ID'];
}
mysql_free_result($result);
return $user;
} 

[logic_earth]

WHERE USERNAME = "s%"

See the error?

[eparkila]

Yep, got it. That is why I love these forums. I was coming back to post my error message and I already had the answer. Thank you!

[SoulScratch]

I do believe that

$result = mysql_query($query, $GLOBALS['DB']); 

Should return a resource ID, so just to be on the safe side I'd do something like

if( is_resource( $result ) ) { 
// do more stuff
} else { echo mysql_error(); } 

So you can actually see the error being output.