mocking a static class (simpletest)

[old_iron]

Hi guys,

If I'm creating a database session class which gets its database connection from a static factory class like so:

class StaticDbFactory {
  static function getInstance($data = null) {
     //return an instance
  }
}
 
class Session {
   static $db;
   function __open() {
        self::$db = StaticDbFactory::getInstance();
    }
}
 
session_set_save_handler(array('Session', 'open') .... ); 
 
Mock::generate('StaticDbFactory');
class TestOfDbSession extends UnitTestCase {
  function setUp() {
      //set up database tables if necessary
      session_start();
  }
  //etc...
}

.. how do I create a MockStaticDbFactory which will return a specific test database? Since the StaticDbFactory method is called statically, I cannot instantiate a MockStaticDbFactory and use the setReturnValue() function to return the test database as I usually would.

any help appreciated!

[FrlB]

Refactor Session:

class Session {
   static $db;
   function __open() {
        self::$db = $this->getDbInstance()
    }
    
    function getDbInstance() {
        return StaticDbFactory::getInstance();
    }
} 

Then extend Session to MyTestSession and override getDbInstance() to return any object you want (your mock) while testing MyTestSession instead of Session.

On the other hand you might consider getting rid of this static stuff (passing the instance to __open()?) - it makes testing hard.

[old_iron]

ideally I'd get rid of the static stuff.. but if I wanted to use a custom session handler using session_set_save_handler() don't all the methods have to be available statically? otherwise I'd definitely prefer to get rid of the static stuff, I just wasn't aware it was possible if I wanted a custom session handler.

[FrlB]

ideally I'd get rid of the static stuff.. but if I wanted to use a custom session handler using session_set_save_handler() don't all the methods have to be available statically? otherwise I'd definitely prefer to get rid of the static stuff, I just wasn't aware it was possible if I wanted a custom session handler.

Sorry, I have no clue about custom session handler callbacks, so please disregard that remark - I thought Session::__open() was completely under your jurisdiction.

[kyberfabrikken]

don't all the methods have to be available statically?

It takes a callback, which can be an objects method. Eg.:

$session = new Session();
session_set_save_handler(array($session, 'open') .... ); 

[old_iron]

It takes a callback, which can be an objects method. Eg.:

$session = new Session();
session_set_save_handler(array($session, 'open') .... ); 

I knew it could be an object's method, I just thought it had to be available statically. Thanks kyber