Yes, I would say those two are absolute "must-do" items. I wouldn't even consider launching the site until those 2 are taken care of.
I can't begin to imagine why the frameset was used. The index.html page is a frameset with two frames: one that displays home.jsp, and one that calls "hidden.html" -- hidden.html contains nothing and that frame has a width and height of 0.
I can see no purpose whatsoever for such a setup. Unless it's something weird having to do with the subdomain on the fastfreenet.com parent domain. What's the purpose for that, BTW? Will this site have its own domain? If they're simply staging the site here, it's possible there's some reason for using the frames during staging but they're not planning to use the frames on the real site.
Fortunately, in this case, taking it out of the frameset is no big deal. Simply make "home.jsp" the default home page (instead of index.html), and change all the links to index.html to link to "/".
Go ahead and load up the site at
http://pausetest.fastfreenet.com/home.jsp, and then click around to various pages -- you'll see that all the individual pages have their own URL in the address bar. So, by simply starting at home.jsp instead of index.html, your frameset problem is magically fixed.
And definitely get those javascript links turned into real href links.
I would personally use URL rewriting to make those URLs more user-friendly and search-engine-friendly -- instead of "catalogue.jsp?request=category_operation¤t=565" for example, I might make that link something like "beverage-equipment.html" or just "beverage-equipment". Although Google recently stated (on their blog, I think) that dynamic URLs like that are fine and rewriting isn't needed. So that's something you'll have to make your own decision about.
I'd also be concerned about the number of validation errors in both the
html and
css, and the use of an XHTML doctype with documents that aren't even valid HTML Transitional.
You've definitely got your work cut out for you, getting this thing whipped into shape. The good news is, any web developer who knows what they're doing shouldn't have any trouble fixing things up.
Bookmarks