Simply Rails 2 ch 6 error pg 168-178

[afowler1]

I am receiving the following error. Thanks


SyntaxError in StoriesController#index

/Users/usdr/shovell/app/controllers/stories_controller.rb:16: syntax error, unexpected $end, expecting kEND

_______________________________________________________________

Copy of stories.controller.rb

class StoriesController < ApplicationController
def index
@story = Story.find(:first, :order => 'RANDOM()')
end
def new
@story = Story.new
end
def create
@story = Story.new(params[:story])
if @story.save
flash[:notice] = 'Story submission succeeded'
redirect_to stories_path
else
render :action => 'new'
end
end

[Mittineague]

Hi afowler1, welcome to the forums,
If you indent you can see code blocks easier. i.e.

class StoriesController < ApplicationController
  def index
    @story = Story.find(:first, :order => 'RANDOM()')
  end
 
  def new
    @story = Story.new
  end
 
  def create
    @story = Story.new(params[:story])
    if @story.save
      flash[:notice] = 'Story submission succeeded'
      redirect_to stories_path
    else
      render :action => 'new' 
    end 
  end

As you can see, you're missing the "end" to close the class definition. The error message is bit confusing, because you may think there is a unexpected "end", when it really indicates that the script "ended" unexpectedly.

[afowler1]

Thank you........ I am still getting the same error, should I check anything else? Also, when I use TextMate my code is indented but for some reason when I copy and paste it overrides the indent. Thank you again for your time.

class StoriesController < ApplicationController
def index
@story = Story.findfirst, rder => 'RANDOM()')
end

def new
@story = Story.new
end

def create
@story = Story.new(params[:story])
if @story.save
flash[:notice] = 'Story submission succeeded'
redirect_to stories_path
else
render :action => 'new'
end
end

[Mittineague]

If you choose "Syntax -> Ruby" from the drop-down select above the post reply box, the indentation will be preserved and there won't be any smilies

.....
  def create
    @story = Story.new(params[:story])
    if @story.save
      flash[:notice] = 'Story submission succeeded'
      redirect_to stories_path
    else
      render :action => 'new'
    end
  end

The "def" needs an "end" to close it, and the "if/else" needs an "end" to close it. But you're still missing the "end" that the class

class StoriesController < ApplicationController
.....
end

needs.

[afowler1]

Great! Thanks for your help. That of course fixed the problem. Have a great day!